RE: [PATCH v4 6/6] net/colo-compare.c: Correct ordering in complete and finalize

2020-05-11 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Friday, May 8, 2020 12:09 AM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: Re: [PATCH v4 6/6] net/colo-compare.c: Correct ordering

RE: [PATCH v4 6/6] net/colo-compare.c: Correct ordering in complete and finalize

2020-05-07 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Friday, May 8, 2020 12:09 AM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: Re: [PATCH v4 6/6] net/colo-compare.c: Correct ordering

Re: [PATCH v4 6/6] net/colo-compare.c: Correct ordering in complete and finalize

2020-05-07 Thread Lukas Straub
; Paolo Bonzini > > > > Subject: [PATCH v4 6/6] net/colo-compare.c: Correct ordering in complete > > and finalize > > > > In colo_compare_complete, insert CompareState into net_compares only > > after everything has been initialized. > > In colo_compare_

RE: [PATCH v4 6/6] net/colo-compare.c: Correct ordering in complete and finalize

2020-05-07 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Monday, May 4, 2020 6:28 PM > To: qemu-devel > Cc: Zhang, Chen ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: [PATCH v4 6/6] net/colo-compare.c: Correct ordering

[PATCH v4 6/6] net/colo-compare.c: Correct ordering in complete and finalize

2020-05-04 Thread Lukas Straub
In colo_compare_complete, insert CompareState into net_compares only after everything has been initialized. In colo_compare_finalize, remove CompareState from net_compares before anything is deinitialized. Signed-off-by: Lukas Straub --- net/colo-compare.c | 45