Re: [PATCH v4 6/8] hw/arm/aspeed: Describe each PCA9552 device

2020-06-24 Thread Cédric Le Goater
On 6/24/20 6:54 PM, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > On Mon, Jun 22, 2020 at 10:35 AM Philippe Mathieu-Daudé > wrote: >> On 6/22/20 8:49 AM, Cédric Le Goater wrote: >>> On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote: We have 2 distinct PCA9552 devices. Set their description

Re: [PATCH v4 6/8] hw/arm/aspeed: Describe each PCA9552 device

2020-06-24 Thread Philippe Mathieu-Daudé
Hi Cédric, On Mon, Jun 22, 2020 at 10:35 AM Philippe Mathieu-Daudé wrote: > On 6/22/20 8:49 AM, Cédric Le Goater wrote: > > On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote: > >> We have 2 distinct PCA9552 devices. Set their description > >> to distinguish them when looking at the trace events.

Re: [PATCH v4 6/8] hw/arm/aspeed: Describe each PCA9552 device

2020-06-22 Thread Philippe Mathieu-Daudé
+Markus On 6/22/20 8:49 AM, Cédric Le Goater wrote: > On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote: >> We have 2 distinct PCA9552 devices. Set their description >> to distinguish them when looking at the trace events. > > It's nice and usefull but couldn't we do the same with a QOM object na

Re: [PATCH v4 6/8] hw/arm/aspeed: Describe each PCA9552 device

2020-06-21 Thread Cédric Le Goater
On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote: > We have 2 distinct PCA9552 devices. Set their description > to distinguish them when looking at the trace events. It's nice and usefull but couldn't we do the same with a QOM object name ? C. > > Description name taken from: > https://githu

[PATCH v4 6/8] hw/arm/aspeed: Describe each PCA9552 device

2020-06-20 Thread Philippe Mathieu-Daudé
We have 2 distinct PCA9552 devices. Set their description to distinguish them when looking at the trace events. Description name taken from: https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/aspeed.c | 13 + 1