Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-13 Thread Kevin Wolf
Am 11.08.2024 um 09:51 hat Michael Tokarev geschrieben: > 12.06.2024 15:43, Amjad Alsharafi wrote: > > These patches fix some bugs found when modifying files in vvfat. > > First, there was a bug when writing to the cluster 2 or above of a file, it > > will copy the cluster before it instead, so, wh

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Amjad Alsharafi
On Aug 11 2024, at 10:45 pm, Michael Tokarev wrote: > The question here is whenever I should include whole series > (5 patches) or just one? I picked up all 5 for now. Yeah, we should include all of them (at least the first 4 are required for the actual fixes), the last one is unit test for

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Michael Tokarev
11.08.2024 13:19, Amjad Alsharafi wrote: ... It would be great to include this patch in `stable`. Thank you. The question here is whenever I should include whole series (5 patches) or just one? I picked up all 5 for now. Thanks, /mjt

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Amjad Alsharafi
On Aug 11 2024, at 6:09 pm, Michael Tokarev wrote: > 11.08.2024 12:52, Amjad Alsharafi wrote: > > Hi! > >> This actually has been reviewed and approved (last version was v6 >> here: >> https://patchew.org/QEMU/cover.1721470238.git.amjadsharaf...@gmail.com/) >> It has been merged into upstre

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Michael Tokarev
11.08.2024 12:52, Amjad Alsharafi wrote: Hi! This actually has been reviewed and approved (last version was v6 here: https://patchew.org/QEMU/cover.1721470238.git.amjadsharaf...@gmail.com/) It has been merged into upstream here: https://gitlab.com/qemu-project/qemu/-/commit/6d00c6f98256ad

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Amjad Alsharafi
On Aug 11 2024, at 3:51 pm, Michael Tokarev wrote: > 12.06.2024 15:43, Amjad Alsharafi wrote: >> These patches fix some bugs found when modifying files in vvfat. >> First, there was a bug when writing to the cluster 2 or above of a >> file, it >> will copy the cluster before it instead, so, wh

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-08-11 Thread Michael Tokarev
12.06.2024 15:43, Amjad Alsharafi wrote: These patches fix some bugs found when modifying files in vvfat. First, there was a bug when writing to the cluster 2 or above of a file, it will copy the cluster before it instead, so, when writing to cluster=2, the content of cluster=1 will be copied int

Re: [PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-07-01 Thread Amjad Alsharafi
Can I get review for this patch? Thanks, Best regards, Amjad On Wed, Jun 12, 2024 at 08:43:21PM +0800, Amjad Alsharafi wrote: > These patches fix some bugs found when modifying files in vvfat. > First, there was a bug when writing to the cluster 2 or above of a file, it > will copy the cluster b

[PATCH v5 0/5] vvfat: Fix write bugs for large files and add iotests

2024-06-12 Thread Amjad Alsharafi
These patches fix some bugs found when modifying files in vvfat. First, there was a bug when writing to the cluster 2 or above of a file, it will copy the cluster before it instead, so, when writing to cluster=2, the content of cluster=1 will be copied into disk instead in its place. Another issue