Re: [PATCH v5 01/18] s390x: Use constant for ESA PSW address

2020-02-27 Thread Cornelia Huck
On Thu, 27 Feb 2020 09:09:47 +0100 Janosch Frank wrote: > On 2/27/20 8:53 AM, Janosch Frank wrote: > > On 2/26/20 6:51 PM, Cornelia Huck wrote: > >> On Wed, 26 Feb 2020 15:27:52 +0100 > >> David Hildenbrand wrote: > >> > >>> On 26.02.20 13:20, Janosch Frank wrote: > Lets make it a

Re: [PATCH v5 01/18] s390x: Use constant for ESA PSW address

2020-02-27 Thread Janosch Frank
On 2/27/20 8:53 AM, Janosch Frank wrote: > On 2/26/20 6:51 PM, Cornelia Huck wrote: >> On Wed, 26 Feb 2020 15:27:52 +0100 >> David Hildenbrand wrote: >> >>> On 26.02.20 13:20, Janosch Frank wrote: Lets make it a bit more clear that we're extracting the 31 bit address >> >> s/Lets/Let's/ :) >

Re: [PATCH v5 01/18] s390x: Use constant for ESA PSW address

2020-02-26 Thread Janosch Frank
On 2/26/20 6:51 PM, Cornelia Huck wrote: > On Wed, 26 Feb 2020 15:27:52 +0100 > David Hildenbrand wrote: > >> On 26.02.20 13:20, Janosch Frank wrote: >>> Lets make it a bit more clear that we're extracting the 31 bit address > > s/Lets/Let's/ :) Ack > >>> from the short psw. >>> >>>

Re: [PATCH v5 01/18] s390x: Use constant for ESA PSW address

2020-02-26 Thread David Hildenbrand
On 26.02.20 18:51, Cornelia Huck wrote: > On Wed, 26 Feb 2020 15:27:52 +0100 > David Hildenbrand wrote: > >> On 26.02.20 13:20, Janosch Frank wrote: >>> Lets make it a bit more clear that we're extracting the 31 bit address > > s/Lets/Let's/ :) > >>> from the short psw. >>> >>> Signed-off-by:

Re: [PATCH v5 01/18] s390x: Use constant for ESA PSW address

2020-02-26 Thread Cornelia Huck
On Wed, 26 Feb 2020 15:27:52 +0100 David Hildenbrand wrote: > On 26.02.20 13:20, Janosch Frank wrote: > > Lets make it a bit more clear that we're extracting the 31 bit address s/Lets/Let's/ :) > > from the short psw. > > > > Signed-off-by: Janosch Frank > > --- > > hw/s390x/ipl.c | 2

Re: [PATCH v5 01/18] s390x: Use constant for ESA PSW address

2020-02-26 Thread David Hildenbrand
On 26.02.20 13:20, Janosch Frank wrote: > Lets make it a bit more clear that we're extracting the 31 bit address > from the short psw. > > Signed-off-by: Janosch Frank > --- > hw/s390x/ipl.c | 2 +- > target/s390x/cpu.c | 4 ++-- > target/s390x/cpu.h | 1 + > 3 files changed, 4

Re: [PATCH v5 01/18] s390x: Use constant for ESA PSW address

2020-02-26 Thread Janosch Frank
On 2/26/20 2:46 PM, Christian Borntraeger wrote: > > > On 26.02.20 13:20, Janosch Frank wrote: >> Lets make it a bit more clear that we're extracting the 31 bit address >> from the short psw. >> >> Signed-off-by: Janosch Frank > > > > PSW_MASK_ESA_MASK and PSW_MASK_ESA_ADDR look pretty

Re: [PATCH v5 01/18] s390x: Use constant for ESA PSW address

2020-02-26 Thread Christian Borntraeger
On 26.02.20 13:20, Janosch Frank wrote: > Lets make it a bit more clear that we're extracting the 31 bit address > from the short psw. > > Signed-off-by: Janosch Frank PSW_MASK_ESA_MASK and PSW_MASK_ESA_ADDR look pretty similar, but I cant find a good name. We could use ~PSW_MASK_ESA_ADDR

[PATCH v5 01/18] s390x: Use constant for ESA PSW address

2020-02-26 Thread Janosch Frank
Lets make it a bit more clear that we're extracting the 31 bit address from the short psw. Signed-off-by: Janosch Frank --- hw/s390x/ipl.c | 2 +- target/s390x/cpu.c | 4 ++-- target/s390x/cpu.h | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/s390x/ipl.c