Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-31 Thread David Gibson
On Tue, Mar 30, 2021 at 11:31:25PM -0700, Richard Henderson wrote: > On 3/30/21 10:47 PM, David Gibson wrote: > > Richard - the remaining possible problem with the hflags stuff seems > > to manifest with the assert failing in the last patch. However, I'm > > guess that's just exposing some more su

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-31 Thread Greg Kurz
On Wed, 31 Mar 2021 15:47:26 +1100 David Gibson wrote: > On Wed, Mar 31, 2021 at 06:04:27AM +0200, Greg Kurz wrote: > > On Wed, 31 Mar 2021 11:09:06 +1100 > > David Gibson wrote: > > > > > On Tue, Mar 30, 2021 at 08:01:13AM -0700, Richard Henderson wrote: > > > > On 3/29/21 10:54 PM, David Gibs

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-30 Thread Richard Henderson
On 3/30/21 10:47 PM, David Gibson wrote: Richard - the remaining possible problem with the hflags stuff seems to manifest with the assert failing in the last patch. However, I'm guess that's just exposing some more subtle problem introduced by an earlier patch. Any chance you could re-order the

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-30 Thread David Gibson
On Wed, Mar 31, 2021 at 06:04:27AM +0200, Greg Kurz wrote: > On Wed, 31 Mar 2021 11:09:06 +1100 > David Gibson wrote: > > > On Tue, Mar 30, 2021 at 08:01:13AM -0700, Richard Henderson wrote: > > > On 3/29/21 10:54 PM, David Gibson wrote: > > > >B) Just the hflags patches from my / Richard's t

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-30 Thread Greg Kurz
On Wed, 31 Mar 2021 11:09:06 +1100 David Gibson wrote: > On Tue, Mar 30, 2021 at 08:01:13AM -0700, Richard Henderson wrote: > > On 3/29/21 10:54 PM, David Gibson wrote: > > >B) Just the hflags patches from my / Richard's tree > > > https://gitlab.com/dgibson/qemu/-/pipelines/278497244 >

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-30 Thread David Gibson
On Tue, Mar 30, 2021 at 08:01:13AM -0700, Richard Henderson wrote: > On 3/29/21 10:54 PM, David Gibson wrote: > >B) Just the hflags patches from my / Richard's tree > > https://gitlab.com/dgibson/qemu/-/pipelines/278497244 > > Look closer at this one -- it's an s390x test that's failing:

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-30 Thread Richard Henderson
On 3/29/21 10:54 PM, David Gibson wrote: B) Just the hflags patches from my / Richard's tree https://gitlab.com/dgibson/qemu/-/pipelines/278497244 Look closer at this one -- it's an s390x test that's failing: make: *** [/builds/dgibson/qemu/tests/Makefile.include:63: run-tcg-tests-s3

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-29 Thread David Gibson
On Mon, Mar 29, 2021 at 10:26:02AM -0600, Richard Henderson wrote: > On 3/29/21 7:05 AM, Greg Kurz wrote: > > On Wed, 24 Mar 2021 11:03:02 +1100 > > David Gibson wrote: > > > > > On Tue, Mar 23, 2021 at 12:43:32PM -0600, Richard Henderson wrote: > > > > Copying flags directly from msr has drawbac

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-29 Thread Richard Henderson
On 3/29/21 7:05 AM, Greg Kurz wrote: On Wed, 24 Mar 2021 11:03:02 +1100 David Gibson wrote: On Tue, Mar 23, 2021 at 12:43:32PM -0600, Richard Henderson wrote: Copying flags directly from msr has drawbacks: (1) msr bits mean different things per cpu, (2) msr has 64 bits on 64 cpus while tb->fl

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-29 Thread Greg Kurz
On Wed, 24 Mar 2021 11:03:02 +1100 David Gibson wrote: > On Tue, Mar 23, 2021 at 12:43:32PM -0600, Richard Henderson wrote: > > Copying flags directly from msr has drawbacks: (1) msr bits > > mean different things per cpu, (2) msr has 64 bits on 64 cpus > > while tb->flags has only 32 bits. > >

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-23 Thread David Gibson
On Tue, Mar 23, 2021 at 12:43:32PM -0600, Richard Henderson wrote: > Copying flags directly from msr has drawbacks: (1) msr bits > mean different things per cpu, (2) msr has 64 bits on 64 cpus > while tb->flags has only 32 bits. > > Create a enum to define these bits. Document the origin of each

[PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-23 Thread Richard Henderson
Copying flags directly from msr has drawbacks: (1) msr bits mean different things per cpu, (2) msr has 64 bits on 64 cpus while tb->flags has only 32 bits. Create a enum to define these bits. Document the origin of each bit and validate those bits that must match MSR. This fixes the truncation o