Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-25 Thread Alex Williamson
On Fri, 25 Oct 2019 12:52:32 +0200 Jens Freimann wrote: > On Wed, Oct 23, 2019 at 12:06:48PM -0600, Alex Williamson wrote: > >On Wed, 23 Oct 2019 10:27:02 +0200 > >Jens Freimann wrote: > [...] > >> @@ -2101,6 +2104,20 @@ static void pci_qdev_realize(DeviceState *qdev, > >> Error **errp) > >>

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-25 Thread Jens Freimann
On Wed, Oct 23, 2019 at 12:06:48PM -0600, Alex Williamson wrote: On Wed, 23 Oct 2019 10:27:02 +0200 Jens Freimann wrote: [...] @@ -2101,6 +2104,20 @@ static void pci_qdev_realize(DeviceState *qdev, Error **errp) } } +if (pci_dev->net_failover_pair_id) { +if

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Jens Freimann
On Thu, Oct 24, 2019 at 10:52:36AM -0600, Alex Williamson wrote: On Thu, 24 Oct 2019 11:37:54 +0200 Jens Freimann wrote: [...] > >While reviewing, I realized that we shouldn't have this check for below reasons. > >1. It is user's responsibility to pass networking device. >But its ok to

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Jens Freimann
On Thu, Oct 24, 2019 at 06:22:27PM +0100, Dr. David Alan Gilbert wrote: * Jens Freimann (jfreim...@redhat.com) wrote: This patch adds a net_failover_pair_id property to PCIDev which is used to link the primary device in a failover pair (the PCI dev) to a standby (a virtio-net-pci) device. It

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Laine Stump
On 10/23/19 5:15 PM, Alex Williamson wrote: On Wed, 23 Oct 2019 22:31:37 +0200 Jens Freimann wrote: On Wed, Oct 23, 2019 at 02:02:11PM -0600, Alex Williamson wrote: On Wed, 23 Oct 2019 21:30:35 +0200 Jens Freimann wrote: On Wed, Oct 23, 2019 at 12:06:48PM -0600, Alex Williamson wrote:

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Dr. David Alan Gilbert
* Jens Freimann (jfreim...@redhat.com) wrote: > This patch adds a net_failover_pair_id property to PCIDev which is > used to link the primary device in a failover pair (the PCI dev) to > a standby (a virtio-net-pci) device. > > It only supports ethernet devices. Also currently it only supports >

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Alex Williamson
.@redhat.com; pkre...@redhat.com; la...@redhat.com; > > aa...@redhat.com; ai...@redhat.com; dgilb...@redhat.com; > > alex.william...@redhat.com > > Subject: Re: [PATCH v5 02/11] pci: add option for net failover > > > > On Thu, Oct 24, 2019 at 05:03:46AM +000

RE: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Parav Pandit
...@redhat.com; dgilb...@redhat.com; > alex.william...@redhat.com > Subject: Re: [PATCH v5 02/11] pci: add option for net failover > > On Thu, Oct 24, 2019 at 05:03:46AM +, Parav Pandit wrote: > >> @@ -2101,6 +2104,20 @@ static void pci_qdev_re

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Alex Williamson
On Thu, 24 Oct 2019 11:37:54 +0200 Jens Freimann wrote: > On Thu, Oct 24, 2019 at 05:03:46AM +, Parav Pandit wrote: > >> @@ -2101,6 +2104,20 @@ static void pci_qdev_realize(DeviceState *qdev, > >> Error **errp) > >> } > >> } > >> > >> +if (pci_dev->net_failover_pair_id) { >

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Jens Freimann
On Thu, Oct 24, 2019 at 05:03:46AM +, Parav Pandit wrote: @@ -2101,6 +2104,20 @@ static void pci_qdev_realize(DeviceState *qdev, Error **errp) } } +if (pci_dev->net_failover_pair_id) { +if (!pci_is_express(pci_dev)) { I am testing and integrating this piece with

RE: [PATCH v5 02/11] pci: add option for net failover

2019-10-24 Thread Parav Pandit
arav Pandit ; > dgilb...@redhat.com; alex.william...@redhat.com > Subject: [PATCH v5 02/11] pci: add option for net failover > > This patch adds a net_failover_pair_id property to PCIDev which is used to > link the primary device in a failover pair (the PCI dev) to a standby (a >

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-23 Thread Alex Williamson
On Wed, 23 Oct 2019 21:30:35 +0200 Jens Freimann wrote: > On Wed, Oct 23, 2019 at 12:06:48PM -0600, Alex Williamson wrote: > >On Wed, 23 Oct 2019 10:27:02 +0200 > >Jens Freimann wrote: > > > >> This patch adds a net_failover_pair_id property to PCIDev which is > >> used to link the primary

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-23 Thread Alex Williamson
On Wed, 23 Oct 2019 22:31:37 +0200 Jens Freimann wrote: > On Wed, Oct 23, 2019 at 02:02:11PM -0600, Alex Williamson wrote: > >On Wed, 23 Oct 2019 21:30:35 +0200 > >Jens Freimann wrote: > > > >> On Wed, Oct 23, 2019 at 12:06:48PM -0600, Alex Williamson wrote: > >> >On Wed, 23 Oct 2019

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-23 Thread Jens Freimann
On Wed, Oct 23, 2019 at 02:02:11PM -0600, Alex Williamson wrote: On Wed, 23 Oct 2019 21:30:35 +0200 Jens Freimann wrote: On Wed, Oct 23, 2019 at 12:06:48PM -0600, Alex Williamson wrote: >On Wed, 23 Oct 2019 10:27:02 +0200 >Jens Freimann wrote: [...] >Are there also multi-function

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-23 Thread Alex Williamson
On Wed, 23 Oct 2019 10:27:02 +0200 Jens Freimann wrote: > This patch adds a net_failover_pair_id property to PCIDev which is > used to link the primary device in a failover pair (the PCI dev) to > a standby (a virtio-net-pci) device. > > It only supports ethernet devices. Also currently it only

Re: [PATCH v5 02/11] pci: add option for net failover

2019-10-23 Thread Jens Freimann
On Wed, Oct 23, 2019 at 12:06:48PM -0600, Alex Williamson wrote: On Wed, 23 Oct 2019 10:27:02 +0200 Jens Freimann wrote: This patch adds a net_failover_pair_id property to PCIDev which is used to link the primary device in a failover pair (the PCI dev) to a standby (a virtio-net-pci) device.

[PATCH v5 02/11] pci: add option for net failover

2019-10-23 Thread Jens Freimann
This patch adds a net_failover_pair_id property to PCIDev which is used to link the primary device in a failover pair (the PCI dev) to a standby (a virtio-net-pci) device. It only supports ethernet devices. Also currently it only supports PCIe devices. QEMU will exit with an error message