Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-09 Thread Markus Armbruster
John Snow writes: > On 10/8/20 3:15 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 10/7/20 4:12 AM, Markus Armbruster wrote: I keep stumbling over things in later patches that turn out to go back to this one. John Snow writes: > This is a minor re-work of t

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-09 Thread Markus Armbruster
John Snow writes: > On 10/8/20 2:51 AM, Markus Armbruster wrote: >> It can be executed by any process. See execve(2): >> >> pathname must be either a binary executable, or a script starting >> with >> a line of the form: >> #!interpreter [optional-arg] >> Fo

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-08 Thread John Snow
On 10/8/20 1:56 AM, Markus Armbruster wrote: John Snow writes: On 10/7/20 3:54 AM, Markus Armbruster wrote: John Snow writes: On 10/6/20 7:51 AM, Markus Armbruster wrote: John Snow writes: This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-08 Thread John Snow
On 10/8/20 3:15 AM, Markus Armbruster wrote: John Snow writes: On 10/7/20 4:12 AM, Markus Armbruster wrote: I keep stumbling over things in later patches that turn out to go back to this one. John Snow writes: This is a minor re-work of the entrypoint script. It isolates a generate() metho

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-08 Thread John Snow
On 10/8/20 2:51 AM, Markus Armbruster wrote: It can be executed by any process. See execve(2): pathname must be either a binary executable, or a script starting with a line of the form: #!interpreter [optional-arg] For details of the latter case, see "Inte

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-08 Thread John Snow
On 10/8/20 2:51 AM, Markus Armbruster wrote: John Snow writes: On 10/7/20 4:07 AM, Markus Armbruster wrote: John Snow writes: This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual command-line mechanism. Signed-off-by: John Snow Reviewed-by: Ed

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-08 Thread Markus Armbruster
John Snow writes: > On 10/7/20 4:12 AM, Markus Armbruster wrote: >> I keep stumbling over things in later patches that turn out to go back >> to this one. >> John Snow writes: >> >>> This is a minor re-work of the entrypoint script. It isolates a >>> generate() method from the actual command-li

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-07 Thread Markus Armbruster
John Snow writes: > On 10/7/20 4:07 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> This is a minor re-work of the entrypoint script. It isolates a >>> generate() method from the actual command-line mechanism. >>> >>> Signed-off-by: John Snow >>> Reviewed-by: Eduardo Habkost >>> Revi

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-07 Thread Markus Armbruster
John Snow writes: > On 10/7/20 3:54 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 10/6/20 7:51 AM, Markus Armbruster wrote: John Snow writes: > This is a minor re-work of the entrypoint script. It isolates a > generate() method from the actual command-line mecha

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-07 Thread John Snow
On 10/7/20 3:54 AM, Markus Armbruster wrote: John Snow writes: On 10/6/20 7:51 AM, Markus Armbruster wrote: John Snow writes: This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual command-line mechanism. Signed-off-by: John Snow Reviewed-by: Ed

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-07 Thread John Snow
On 10/7/20 4:12 AM, Markus Armbruster wrote: I keep stumbling over things in later patches that turn out to go back to this one. John Snow writes: This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual command-line mechanism. Signed-off-by: John Sno

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-07 Thread John Snow
On 10/7/20 4:07 AM, Markus Armbruster wrote: John Snow writes: This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual command-line mechanism. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa --

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-07 Thread Markus Armbruster
I keep stumbling over things in later patches that turn out to go back to this one. John Snow writes: > This is a minor re-work of the entrypoint script. It isolates a > generate() method from the actual command-line mechanism. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Revi

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-07 Thread Markus Armbruster
John Snow writes: > This is a minor re-work of the entrypoint script. It isolates a > generate() method from the actual command-line mechanism. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > Tested-by: Cleber Rosa > --- > scripts/qapi-gen.py | 85 +++

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-07 Thread Markus Armbruster
John Snow writes: > On 10/6/20 7:51 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> This is a minor re-work of the entrypoint script. It isolates a >>> generate() method from the actual command-line mechanism. >>> >>> Signed-off-by: John Snow >>> Reviewed-by: Eduardo Habkost >>> Revi

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-06 Thread John Snow
On 10/6/20 7:51 AM, Markus Armbruster wrote: John Snow writes: This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual command-line mechanism. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa --

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-06 Thread John Snow
On 10/6/20 7:51 AM, Markus Armbruster wrote: John Snow writes: This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual command-line mechanism. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa --

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-06 Thread Markus Armbruster
John Snow writes: > This is a minor re-work of the entrypoint script. It isolates a > generate() method from the actual command-line mechanism. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > Tested-by: Cleber Rosa > --- > scripts/qapi-gen.py | 85 +++

[PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-05 Thread John Snow
This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual command-line mechanism. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa --- scripts/qapi-gen.py | 85 +---