[PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

2023-02-20 Thread Bin Meng
From: Guohuai Shi This commit implements Windows specific xxxdir() APIs for safety directory access. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- hw/9pfs/9p-util.h | 6 + hw/9pfs/9p-util-win32.c | 443 2 files changed, 449 insertions

Re: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

2023-03-14 Thread Christian Schoenebeck
On Monday, February 20, 2023 11:08:03 AM CET Bin Meng wrote: > From: Guohuai Shi > > This commit implements Windows specific xxxdir() APIs for safety > directory access. That comment is seriously too short for this patch. 1. You should describe the behaviour implementation that you have chosen

RE: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

2023-03-15 Thread Shi, Guohuai
> -Original Message- > From: Christian Schoenebeck > Sent: Wednesday, March 15, 2023 00:06 > To: Greg Kurz ; qemu-devel@nongnu.org > Cc: Shi, Guohuai ; Meng, Bin > > Subject: Re: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() > APIs > > CA

Re: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

2023-03-16 Thread Christian Schoenebeck
On Wednesday, March 15, 2023 8:05:34 PM CET Shi, Guohuai wrote: > > > -Original Message- > > From: Christian Schoenebeck > > Sent: Wednesday, March 15, 2023 00:06 > > To: Greg Kurz ; qemu-devel@nongnu.org > > Cc: Shi, Guohuai ; Meng, Bin > > &g

RE: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

2023-03-16 Thread Shi, Guohuai
> -Original Message- > From: Christian Schoenebeck > Sent: Thursday, March 16, 2023 19:05 > To: Greg Kurz ; qemu-devel@nongnu.org > Cc: Meng, Bin ; Shi, Guohuai > > Subject: Re: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() > APIs > > CA

RE: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

2023-03-16 Thread Shi, Guohuai
> -Original Message- > From: Shi, Guohuai > Sent: Friday, March 17, 2023 01:28 > To: Christian Schoenebeck ; Greg Kurz > ; qemu-devel@nongnu.org > Cc: Meng, Bin > Subject: RE: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() > APIs > >

Re: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

2023-03-17 Thread Christian Schoenebeck
On Friday, March 17, 2023 5:36:37 AM CET Shi, Guohuai wrote: [...] > > > > > > +do { > > > > > > +full_dir_entry = get_full_path_win32(hDir, > > > > > > + dd_data.name); > > > > > > + > > > > > > +if (full_dir_entry == NULL) { > > > > > > +err = ENOMEM; > > > > > > +