Re: [PATCH v5 04/18] dump: Rework get_start_block

2022-09-26 Thread Janosch Frank
On 8/29/22 22:17, Janis Schoetterl-Glausch wrote: On Thu, 2022-08-11 at 12:10 +, Janosch Frank wrote: get_start_block() returns the start address of the first memory block or -1. With the GuestPhysBlock iterator conversion we don't need to set the start address and can therefore remove that

Re: [PATCH v5 04/18] dump: Rework get_start_block

2022-08-29 Thread Janis Schoetterl-Glausch
On Thu, 2022-08-11 at 12:10 +, Janosch Frank wrote: > get_start_block() returns the start address of the first memory block > or -1. > > With the GuestPhysBlock iterator conversion we don't need to set the > start address and can therefore remove that code and the "start" > DumpState struct me

[PATCH v5 04/18] dump: Rework get_start_block

2022-08-11 Thread Janosch Frank
get_start_block() returns the start address of the first memory block or -1. With the GuestPhysBlock iterator conversion we don't need to set the start address and can therefore remove that code and the "start" DumpState struct member. The only functionality left is the validation of the start blo