Re: [PATCH v5 04/21] net: Remove receive_raw()

2023-10-29 Thread Akihiko Odaki
On 2023/10/30 13:08, Jason Wang wrote: On Mon, Oct 30, 2023 at 12:03 PM Akihiko Odaki wrote: On 2023/10/30 12:06, Jason Wang wrote: 在 2023/10/27 15:52, Akihiko Odaki 写道: On 2023/10/27 15:49, Jason Wang wrote: On Tue, Oct 17, 2023 at 12:09 PM Akihiko Odaki wrote: While netmap implements

Re: [PATCH v5 04/21] net: Remove receive_raw()

2023-10-29 Thread Jason Wang
On Mon, Oct 30, 2023 at 12:03 PM Akihiko Odaki wrote: > > On 2023/10/30 12:06, Jason Wang wrote: > > > > 在 2023/10/27 15:52, Akihiko Odaki 写道: > >> On 2023/10/27 15:49, Jason Wang wrote: > >>> On Tue, Oct 17, 2023 at 12:09 PM Akihiko Odaki > >>> wrote: > > While netmap implements virtio

Re: [PATCH v5 04/21] net: Remove receive_raw()

2023-10-29 Thread Akihiko Odaki
On 2023/10/30 12:06, Jason Wang wrote: 在 2023/10/27 15:52, Akihiko Odaki 写道: On 2023/10/27 15:49, Jason Wang wrote: On Tue, Oct 17, 2023 at 12:09 PM Akihiko Odaki wrote: While netmap implements virtio-net header, it does not implement receive_raw(). The only user for raw is the announcing

Re: [PATCH v5 04/21] net: Remove receive_raw()

2023-10-29 Thread Jason Wang
在 2023/10/27 15:52, Akihiko Odaki 写道: On 2023/10/27 15:49, Jason Wang wrote: On Tue, Oct 17, 2023 at 12:09 PM Akihiko Odaki wrote: While netmap implements virtio-net header, it does not implement receive_raw(). The only user for raw is the announcing. Netmap probably doesn't it at all.

Re: [PATCH v5 04/21] net: Remove receive_raw()

2023-10-27 Thread Akihiko Odaki
On 2023/10/27 15:49, Jason Wang wrote: On Tue, Oct 17, 2023 at 12:09 PM Akihiko Odaki wrote: While netmap implements virtio-net header, it does not implement receive_raw(). The only user for raw is the announcing. Netmap probably doesn't it at all. In my understanding, the announcing *send

Re: [PATCH v5 04/21] net: Remove receive_raw()

2023-10-26 Thread Jason Wang
On Tue, Oct 17, 2023 at 12:09 PM Akihiko Odaki wrote: > > While netmap implements virtio-net header, it does not implement > receive_raw(). The only user for raw is the announcing. Netmap probably doesn't it at all. > Instead of implementing receive_raw for netmap, add > virtio-net headers in th

[PATCH v5 04/21] net: Remove receive_raw()

2023-10-16 Thread Akihiko Odaki
While netmap implements virtio-net header, it does not implement receive_raw(). Instead of implementing receive_raw for netmap, add virtio-net headers in the common code and use receive_iov()/receive() instead. This also fixes the buffer size for the virtio-net header. Fixes: fbbdbddec0 ("tap: all