Re: [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls

2020-07-14 Thread John Snow
On 7/13/20 10:48 PM, Cleber Rosa wrote: > On Fri, Jul 10, 2020 at 01:06:42AM -0400, John Snow wrote: >> If the VM is not launched, don't try to shut it down. As a change, >> _post_shutdown now unconditionally also calls _early_cleanup in order to >> offer comprehensive object cleanup in failure

Re: [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls

2020-07-14 Thread John Snow
On 7/13/20 10:48 PM, Cleber Rosa wrote: > On Fri, Jul 10, 2020 at 01:06:42AM -0400, John Snow wrote: >> If the VM is not launched, don't try to shut it down. As a change, >> _post_shutdown now unconditionally also calls _early_cleanup in order to >> offer comprehensive object cleanup in failure

Re: [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls

2020-07-13 Thread Cleber Rosa
On Fri, Jul 10, 2020 at 01:06:42AM -0400, John Snow wrote: > If the VM is not launched, don't try to shut it down. As a change, > _post_shutdown now unconditionally also calls _early_cleanup in order to > offer comprehensive object cleanup in failure cases. > > As a courtesy, treat it as a NOP

Re: [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/10/20 7:06 AM, John Snow wrote: > If the VM is not launched, don't try to shut it down. As a change, > _post_shutdown now unconditionally also calls _early_cleanup in order to > offer comprehensive object cleanup in failure cases. > > As a courtesy, treat it as a NOP instead of rejecting it

[PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls

2020-07-09 Thread John Snow
If the VM is not launched, don't try to shut it down. As a change, _post_shutdown now unconditionally also calls _early_cleanup in order to offer comprehensive object cleanup in failure cases. As a courtesy, treat it as a NOP instead of rejecting it as an error. This is slightly nicer for