Re: [PATCH v5 06/11] qapi: add failover negotiated event

2019-10-25 Thread Jens Freimann
On Fri, Oct 25, 2019 at 07:35:28AM +0200, Markus Armbruster wrote: We ask patch submitters to cc: subject matter experts for review. You did. When such patches touch the QAPI schema, it's best to cc the qapi schema maintainers (Eric Blake and me) as well, because we can't require all subject ma

Re: [PATCH v5 06/11] qapi: add failover negotiated event

2019-10-24 Thread Markus Armbruster
We ask patch submitters to cc: subject matter experts for review. You did. When such patches touch the QAPI schema, it's best to cc the qapi schema maintainers (Eric Blake and me) as well, because we can't require all subject matter experts to be fluent in the QAPI schema language and conventions

Re: [PATCH v5 06/11] qapi: add failover negotiated event

2019-10-24 Thread Jens Freimann
On Thu, Oct 24, 2019 at 06:32:45PM +0100, Dr. David Alan Gilbert wrote: * Jens Freimann (jfreim...@redhat.com) wrote: This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature was not negotiated during virtio feature negotiation. If this event is received it means any primary devi

Re: [PATCH v5 06/11] qapi: add failover negotiated event

2019-10-24 Thread Dr. David Alan Gilbert
* Jens Freimann (jfreim...@redhat.com) wrote: > This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY > feature was not negotiated during virtio feature negotiation. If this > event is received it means any primary devices hotplugged before > this were were never really added to QEMU dev

[PATCH v5 06/11] qapi: add failover negotiated event

2019-10-23 Thread Jens Freimann
This event is sent to let libvirt know that VIRTIO_NET_F_STANDBY feature was not negotiated during virtio feature negotiation. If this event is received it means any primary devices hotplugged before this were were never really added to QEMU devices. Signed-off-by: Jens Freimann --- qapi/net.jso