Re: [PATCH v5 06/12] python/machine.py: Add a configurable timeout to shutdown()

2020-07-13 Thread Cleber Rosa
On Fri, Jul 10, 2020 at 01:06:43AM -0400, John Snow wrote: > Three seconds is hardcoded. Use it as a default parameter instead, and use > that > value for both waits that may occur in the function. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 8 +--- > 1 file changed, 5 ins

Re: [PATCH v5 06/12] python/machine.py: Add a configurable timeout to shutdown()

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/10/20 7:06 AM, John Snow wrote: > Three seconds is hardcoded. Use it as a default parameter instead, and use > that > value for both waits that may occur in the function. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 8 +--- > 1 file changed, 5 insertions(+), 3 deletion

[PATCH v5 06/12] python/machine.py: Add a configurable timeout to shutdown()

2020-07-09 Thread John Snow
Three seconds is hardcoded. Use it as a default parameter instead, and use that value for both waits that may occur in the function. Signed-off-by: John Snow --- python/qemu/machine.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/python/qemu/machine.py b/python/qem