Re: [PATCH v5 06/29] e1000e: Mask registers when writing

2023-02-21 Thread Philippe Mathieu-Daudé
On 1/2/23 04:35, Akihiko Odaki wrote: When a register has effective bits fewer than their width, the old code inconsistently masked when writing or reading. Make the code consistent by always masking when writing, and remove some code duplication. Signed-off-by: Akihiko Odaki --- hw/net/e1000

[PATCH v5 06/29] e1000e: Mask registers when writing

2023-01-31 Thread Akihiko Odaki
When a register has effective bits fewer than their width, the old code inconsistently masked when writing or reading. Make the code consistent by always masking when writing, and remove some code duplication. Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 94 +++