Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-03 Thread Alistair Francis
On Wed, Jun 3, 2020 at 10:06 PM LIU Zhiwei wrote: > > > > On 2020/6/4 12:35, Alistair Francis wrote: > > On Wed, Jun 3, 2020 at 6:59 PM LIU Zhiwei wrote: > >> > >> > >> On 2020/6/3 23:56, Alistair Francis wrote: > >>> On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote: > On 2020/6/3 1:54, Alis

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-03 Thread LIU Zhiwei
On 2020/6/4 12:35, Alistair Francis wrote: On Wed, Jun 3, 2020 at 6:59 PM LIU Zhiwei wrote: On 2020/6/3 23:56, Alistair Francis wrote: On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote: On 2020/6/3 1:54, Alistair Francis wrote: On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote: Hi Alista

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-03 Thread LIU Zhiwei
On 2020/6/4 12:35, Alistair Francis wrote: On Wed, Jun 3, 2020 at 6:59 PM LIU Zhiwei wrote: On 2020/6/3 23:56, Alistair Francis wrote: On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote: On 2020/6/3 1:54, Alistair Francis wrote: On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote: Hi Alista

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-03 Thread Alistair Francis
On Wed, Jun 3, 2020 at 6:59 PM LIU Zhiwei wrote: > > > > On 2020/6/3 23:56, Alistair Francis wrote: > > On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote: > >> On 2020/6/3 1:54, Alistair Francis wrote: > >>> On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote: > Hi Alistair, > > There a

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-03 Thread LIU Zhiwei
On 2020/6/3 23:56, Alistair Francis wrote: On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote: On 2020/6/3 1:54, Alistair Francis wrote: On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote: Hi Alistair, There are still some questions I don't understand. 1. Is the baud rate or fifo a necessary

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-03 Thread Alistair Francis
On Wed, Jun 3, 2020 at 3:33 AM LIU Zhiwei wrote: > > On 2020/6/3 1:54, Alistair Francis wrote: > > On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote: > >> Hi Alistair, > >> > >> There are still some questions I don't understand. > >> > >> 1. Is the baud rate or fifo a necessary feature to simulate

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-03 Thread LIU Zhiwei
On 2020/6/3 1:54, Alistair Francis wrote: On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote: Hi Alistair, There are still some questions I don't understand. 1. Is the baud rate or fifo a necessary feature to simulate? As you can see, qemu_chr_fe_write will send the byte as soon as possible. Wh

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-02 Thread Alistair Francis
On Tue, Jun 2, 2020 at 5:28 AM LIU Zhiwei wrote: > > Hi Alistair, > > There are still some questions I don't understand. > > 1. Is the baud rate or fifo a necessary feature to simulate? > As you can see, qemu_chr_fe_write will send the byte as soon as possible. > When you want to transmit a byte

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-02 Thread Alistair Francis
On Tue, Jun 2, 2020 at 4:22 AM LIU Zhiwei wrote: > > > > On 2020/5/29 6:14, Alistair Francis wrote: > > This is the initial commit of the Ibex UART device. Serial TX is > > working, while RX has been implemeneted but untested. > > > > This is based on the documentation from: > > https://docs.opent

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-02 Thread LIU Zhiwei
Hi Alistair, There are still some questions I don't understand. 1. Is the baud rate  or fifo a necessary feature to simulate? As you can see, qemu_chr_fe_write will send the byte as soon as possible. When you want to transmit a byte through WDATA,  you can call qemu_chr_fe_write directly. 2. 

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-02 Thread LIU Zhiwei
On 2020/5/29 6:14, Alistair Francis wrote: This is the initial commit of the Ibex UART device. Serial TX is working, while RX has been implemeneted but untested. This is based on the documentation from: https://docs.opentitan.org/hw/ip/uart/doc/ Signed-off-by: Alistair Francis --- include

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-01 Thread Alistair Francis
On Thu, May 28, 2020 at 3:23 PM Alistair Francis wrote: > > This is the initial commit of the Ibex UART device. Serial TX is > working, while RX has been implemeneted but untested. > > This is based on the documentation from: > https://docs.opentitan.org/hw/ip/uart/doc/ > > Signed-off-by: Alistair

[PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-05-28 Thread Alistair Francis
This is the initial commit of the Ibex UART device. Serial TX is working, while RX has been implemeneted but untested. This is based on the documentation from: https://docs.opentitan.org/hw/ip/uart/doc/ Signed-off-by: Alistair Francis --- include/hw/char/ibex_uart.h | 110 hw/char/ibex