Re: [PATCH v5 09/12] tests/acceptance: Don't test reboot on cubieboard

2020-07-13 Thread Cleber Rosa
On Fri, Jul 10, 2020 at 01:06:46AM -0400, John Snow wrote: > cubieboard does not have a functioning reboot, it halts and QEMU does > not exit. > > vm.shutdown() is modified in a forthcoming patch that makes it less tolerant > of race conditions on shutdown; tests should consciously decide to WAIT

Re: [PATCH v5 09/12] tests/acceptance: Don't test reboot on cubieboard

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/13/20 5:12 PM, John Snow wrote: > > > On 7/13/20 5:56 AM, Philippe Mathieu-Daudé wrote: >> On 7/10/20 7:06 AM, John Snow wrote: >>> cubieboard does not have a functioning reboot, it halts and QEMU does >>> not exit. >>> >>> vm.shutdown() is modified in a forthcoming patch that makes it less

Re: [PATCH v5 09/12] tests/acceptance: Don't test reboot on cubieboard

2020-07-13 Thread John Snow
On 7/13/20 5:56 AM, Philippe Mathieu-Daudé wrote: > On 7/10/20 7:06 AM, John Snow wrote: >> cubieboard does not have a functioning reboot, it halts and QEMU does >> not exit. >> >> vm.shutdown() is modified in a forthcoming patch that makes it less tolerant >> of race conditions on shutdown; tes

Re: [PATCH v5 09/12] tests/acceptance: Don't test reboot on cubieboard

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/10/20 7:06 AM, John Snow wrote: > cubieboard does not have a functioning reboot, it halts and QEMU does > not exit. > > vm.shutdown() is modified in a forthcoming patch that makes it less tolerant > of race conditions on shutdown; tests should consciously decide to WAIT > or to SHUTDOWN qemu.

[PATCH v5 09/12] tests/acceptance: Don't test reboot on cubieboard

2020-07-09 Thread John Snow
cubieboard does not have a functioning reboot, it halts and QEMU does not exit. vm.shutdown() is modified in a forthcoming patch that makes it less tolerant of race conditions on shutdown; tests should consciously decide to WAIT or to SHUTDOWN qemu. So long as this test is attempting to reboot, t