RE: [PATCH v5 1/1] colo-compare: Fix memory leak in packet_enqueue()

2020-04-26 Thread Zhang, Chen
Re: [PATCH v5 1/1] colo-compare: Fix memory leak in > packet_enqueue() > > On Fri, 10 Apr 2020 10:00:56 +0800 > Derek Su wrote: > > > The patch is to fix the "pkt" memory leak in packet_enqueue(). > > The allocated "pkt" needs to be freed if the

Re: [PATCH v5 1/1] colo-compare: Fix memory leak in packet_enqueue()

2020-04-26 Thread Lukas Straub
On Fri, 10 Apr 2020 10:00:56 +0800 Derek Su wrote: > The patch is to fix the "pkt" memory leak in packet_enqueue(). > The allocated "pkt" needs to be freed if the colo compare > primary or secondary queue is too big. > > Replace the error_report of full queue with a trace event. > >

RE: [PATCH v5 1/1] colo-compare: Fix memory leak in packet_enqueue()

2020-04-10 Thread Zhang, Chen
> -Original Message- > From: Derek Su > Sent: Friday, April 10, 2020 10:01 AM > To: qemu-devel@nongnu.org > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; ctch...@qnap.com; chy...@qnap.com; > jwsu1...@gmail.com; Derek Su > Subject: [PATCH v

[PATCH v5 1/1] colo-compare: Fix memory leak in packet_enqueue()

2020-04-09 Thread Derek Su
The patch is to fix the "pkt" memory leak in packet_enqueue(). The allocated "pkt" needs to be freed if the colo compare primary or secondary queue is too big. Replace the error_report of full queue with a trace event. Signed-off-by: Derek Su --- net/colo-compare.c | 23 +++