Re: [PATCH v5 1/2] tpm: convert tpmdev options processing to new visitor format

2023-01-09 Thread Daniel P . Berrangé
On Thu, Jan 05, 2023 at 03:34:50PM -0500, James Bottomley wrote: > On Thu, 2023-01-05 at 09:59 -0500, Stefan Berger wrote: > [...] > > > @@ -2658,7 +2646,6 @@ void qemu_init(int argc, char **argv) > > >   qemu_add_opts(&qemu_boot_opts); > > >   qemu_add_opts(&qemu_add_fd_opts); > > >  

Re: [PATCH v5 1/2] tpm: convert tpmdev options processing to new visitor format

2023-01-05 Thread James Bottomley
On Thu, 2023-01-05 at 09:59 -0500, Stefan Berger wrote: [...] > > @@ -2658,7 +2646,6 @@ void qemu_init(int argc, char **argv) > >   qemu_add_opts(&qemu_boot_opts); > >   qemu_add_opts(&qemu_add_fd_opts); > >   qemu_add_opts(&qemu_object_opts); > > -    qemu_add_opts(&qemu_tpmdev_opts);

Re: [PATCH v5 1/2] tpm: convert tpmdev options processing to new visitor format

2023-01-05 Thread Stefan Berger
On 1/5/23 08:00, James Bottomley wrote: From: James Bottomley Instead of processing the tpmdev options using the old qemu options, convert to the new visitor format which also allows the passing of json on the command line. Signed-off-by: James Bottomley --- v4: add TpmConfiOptions ---

[PATCH v5 1/2] tpm: convert tpmdev options processing to new visitor format

2023-01-05 Thread James Bottomley
From: James Bottomley Instead of processing the tpmdev options using the old qemu options, convert to the new visitor format which also allows the passing of json on the command line. Signed-off-by: James Bottomley --- v4: add TpmConfiOptions --- backends/tpm/tpm_emulator.c| 24 -