Re: [PATCH v5 1/5] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2019-12-18 Thread David Gibson
On Wed, Dec 18, 2019 at 08:59:18PM -0500, Stefan Berger wrote: > On 12/18/19 8:54 PM, David Gibson wrote: > > On Tue, Dec 17, 2019 at 02:44:04PM -0500, Stefan Berger wrote: > > > On 12/16/19 7:29 PM, David Gibson wrote: > > > > > > > > > > Since you need to change compatible based on an internal

Re: [PATCH v5 1/5] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2019-12-18 Thread David Gibson
On Thu, Dec 19, 2019 at 04:13:57PM +1100, David Gibson wrote: > On Wed, Dec 18, 2019 at 08:59:18PM -0500, Stefan Berger wrote: > > On 12/18/19 8:54 PM, David Gibson wrote: > > > On Tue, Dec 17, 2019 at 02:44:04PM -0500, Stefan Berger wrote: > > > > On 12/16/19 7:29 PM, David Gibson wrote: > > > >

Re: [PATCH v5 1/5] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2019-12-18 Thread Stefan Berger
On 12/18/19 8:54 PM, David Gibson wrote: On Tue, Dec 17, 2019 at 02:44:04PM -0500, Stefan Berger wrote: On 12/16/19 7:29 PM, David Gibson wrote: Since you need to change compatible based on an internal variable, we'd need to replace the static dt_compatible in the class with a callback. Why

Re: [PATCH v5 1/5] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2019-12-18 Thread David Gibson
On Tue, Dec 17, 2019 at 02:44:04PM -0500, Stefan Berger wrote: > On 12/16/19 7:29 PM, David Gibson wrote: > > On Fri, Dec 13, 2019 at 08:03:36AM -0500, Stefan Berger wrote: > > > On 12/13/19 12:34 AM, David Gibson wrote: > > > > > > The existing one looks like this: > > > > > > typedef struct Spa

Re: [PATCH v5 1/5] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2019-12-17 Thread Stefan Berger
On 12/16/19 7:29 PM, David Gibson wrote: On Fri, Dec 13, 2019 at 08:03:36AM -0500, Stefan Berger wrote: On 12/13/19 12:34 AM, David Gibson wrote: The existing one looks like this: typedef struct SpaprVioCrq {     uint64_t qladdr;     uint32_t qsize;     uint32_t qnext;     int(*SendFunc)(s

Re: [PATCH v5 1/5] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2019-12-16 Thread David Gibson
On Fri, Dec 13, 2019 at 08:03:36AM -0500, Stefan Berger wrote: > On 12/13/19 12:34 AM, David Gibson wrote: > > On Thu, Dec 12, 2019 at 03:24:26PM -0500, Stefan Berger wrote: > > > Implement support for TPM on ppc64 by implementing the vTPM CRQ interface > > > as a frontend. It can use the tpm_emula

Re: [PATCH v5 1/5] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2019-12-13 Thread Stefan Berger
On 12/13/19 12:34 AM, David Gibson wrote: On Thu, Dec 12, 2019 at 03:24:26PM -0500, Stefan Berger wrote: Implement support for TPM on ppc64 by implementing the vTPM CRQ interface as a frontend. It can use the tpm_emulator driver backend with the external swtpm. The Linux vTPM driver for ppc64 w

Re: [PATCH v5 1/5] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2019-12-12 Thread David Gibson
On Thu, Dec 12, 2019 at 03:24:26PM -0500, Stefan Berger wrote: > Implement support for TPM on ppc64 by implementing the vTPM CRQ interface > as a frontend. It can use the tpm_emulator driver backend with the external > swtpm. > > The Linux vTPM driver for ppc64 works with this emulation. > > This

Re: [PATCH v5 1/5] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2019-12-12 Thread Stefan Berger
On 12/12/19 3:33 PM, Eric Blake wrote: On 12/12/19 2:24 PM, Stefan Berger wrote: Implement support for TPM on ppc64 by implementing the vTPM CRQ interface as a frontend. It can use the tpm_emulator driver backend with the external swtpm. The Linux vTPM driver for ppc64 works with this emulati

Re: [PATCH v5 1/5] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2019-12-12 Thread Eric Blake
On 12/12/19 2:24 PM, Stefan Berger wrote: Implement support for TPM on ppc64 by implementing the vTPM CRQ interface as a frontend. It can use the tpm_emulator driver backend with the external swtpm. The Linux vTPM driver for ppc64 works with this emulation. This TPM emulator also handles the TP

[PATCH v5 1/5] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2019-12-12 Thread Stefan Berger
Implement support for TPM on ppc64 by implementing the vTPM CRQ interface as a frontend. It can use the tpm_emulator driver backend with the external swtpm. The Linux vTPM driver for ppc64 works with this emulation. This TPM emulator also handles the TPM 2 case. Signed-off-by: Stefan Berger Rev