Re: [PATCH v5 10/12] python/machine.py: split shutdown into hard and soft flavors

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/14/20 8:13 PM, John Snow wrote: > > > On 7/14/20 12:13 AM, Cleber Rosa wrote: >> On Fri, Jul 10, 2020 at 01:06:47AM -0400, John Snow wrote: >>> This is done primarily to avoid the 'bare except' pattern, which >>> suppresses all exceptions during shutdown and can obscure errors. >>> >>> Repla

Re: [PATCH v5 10/12] python/machine.py: split shutdown into hard and soft flavors

2020-07-14 Thread John Snow
On 7/14/20 12:13 AM, Cleber Rosa wrote: > On Fri, Jul 10, 2020 at 01:06:47AM -0400, John Snow wrote: >> This is done primarily to avoid the 'bare except' pattern, which >> suppresses all exceptions during shutdown and can obscure errors. >> >> Replace this with a pattern that isolates the differ

Re: [PATCH v5 10/12] python/machine.py: split shutdown into hard and soft flavors

2020-07-13 Thread Cleber Rosa
On Fri, Jul 10, 2020 at 01:06:47AM -0400, John Snow wrote: > This is done primarily to avoid the 'bare except' pattern, which > suppresses all exceptions during shutdown and can obscure errors. > > Replace this with a pattern that isolates the different kind of shutdown > paradigms (_hard_shutdown

Re: [PATCH v5 10/12] python/machine.py: split shutdown into hard and soft flavors

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/10/20 7:06 AM, John Snow wrote: > This is done primarily to avoid the 'bare except' pattern, which > suppresses all exceptions during shutdown and can obscure errors. > > Replace this with a pattern that isolates the different kind of shutdown > paradigms (_hard_shutdown and _soft_shutdown),

[PATCH v5 10/12] python/machine.py: split shutdown into hard and soft flavors

2020-07-09 Thread John Snow
This is done primarily to avoid the 'bare except' pattern, which suppresses all exceptions during shutdown and can obscure errors. Replace this with a pattern that isolates the different kind of shutdown paradigms (_hard_shutdown and _soft_shutdown), and a new fallback shutdown handler (_do_shutdo