Re: [PATCH v5 11/36] qapi/common.py: Add indent manager

2020-10-08 Thread John Snow
On 10/8/20 3:23 AM, Markus Armbruster wrote: Eduardo Habkost writes: On Wed, Oct 07, 2020 at 02:08:33PM -0400, John Snow wrote: On 10/7/20 4:50 AM, Markus Armbruster wrote: John Snow writes: Code style tools really dislike the use of global keywords, because it generally involves re-bindi

Re: [PATCH v5 11/36] qapi/common.py: Add indent manager

2020-10-08 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Oct 07, 2020 at 02:08:33PM -0400, John Snow wrote: >> On 10/7/20 4:50 AM, Markus Armbruster wrote: >> > John Snow writes: >> > >> > > Code style tools really dislike the use of global keywords, because it >> > > generally involves re-binding the name at runtime

Re: [PATCH v5 11/36] qapi/common.py: Add indent manager

2020-10-07 Thread Eduardo Habkost
On Wed, Oct 07, 2020 at 02:08:33PM -0400, John Snow wrote: > On 10/7/20 4:50 AM, Markus Armbruster wrote: > > John Snow writes: > > > > > Code style tools really dislike the use of global keywords, because it > > > generally involves re-binding the name at runtime which can have strange > > > eff

Re: [PATCH v5 11/36] qapi/common.py: Add indent manager

2020-10-07 Thread John Snow
On 10/7/20 4:50 AM, Markus Armbruster wrote: John Snow writes: Code style tools really dislike the use of global keywords, because it generally involves re-binding the name at runtime which can have strange effects depending on when and how that global name is referenced in other modules. Mak

Re: [PATCH v5 11/36] qapi/common.py: Add indent manager

2020-10-07 Thread Markus Armbruster
John Snow writes: > Code style tools really dislike the use of global keywords, because it > generally involves re-binding the name at runtime which can have strange > effects depending on when and how that global name is referenced in > other modules. > > Make a little indent level manager inste

[PATCH v5 11/36] qapi/common.py: Add indent manager

2020-10-05 Thread John Snow
Code style tools really dislike the use of global keywords, because it generally involves re-binding the name at runtime which can have strange effects depending on when and how that global name is referenced in other modules. Make a little indent level manager instead. Signed-off-by: John Snow