Re: [PATCH v5 13/16] python/machine.py: fix _popen access

2020-07-13 Thread Philippe Mathieu-Daudé
On 7/10/20 7:22 AM, John Snow wrote: > As always, Optional[T] causes problems with unchecked access. Add a > helper that asserts the pipe is present before we attempt to talk with > it. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 16 +++- > 1 file changed, 11 insert

[PATCH v5 13/16] python/machine.py: fix _popen access

2020-07-09 Thread John Snow
As always, Optional[T] causes problems with unchecked access. Add a helper that asserts the pipe is present before we attempt to talk with it. Signed-off-by: John Snow --- python/qemu/machine.py | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/python/qemu/mac