Re: [PATCH v5 13/31] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap()

2020-05-06 Thread Alberto Garcia
On Tue 05 May 2020 10:04:32 PM CEST, Eric Blake wrote: > What happens for an image whose size is not cluster-aligned? Must the > bits corresponding to subclusters not present in the final cluster > always be zero, or are they instead ignored regardless of value? Attempting to read or write beyond

Re: [PATCH v5 13/31] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap()

2020-05-05 Thread Eric Blake
On 5/5/20 12:38 PM, Alberto Garcia wrote: Extended L2 entries are 128-bit wide: 64 bits for the entry itself and 64 bits for the subcluster allocation bitmap. In order to support them correctly get/set_l2_entry() need to be updated so they take the entry width into account in order to calculate

[PATCH v5 13/31] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap()

2020-05-05 Thread Alberto Garcia
Extended L2 entries are 128-bit wide: 64 bits for the entry itself and 64 bits for the subcluster allocation bitmap. In order to support them correctly get/set_l2_entry() need to be updated so they take the entry width into account in order to calculate the correct offset. This patch also adds th