Re: [PATCH v5 2/2] migration: Update error description outside migration.c

2023-10-04 Thread Juan Quintela
Juan Quintela wrote: > Tejus GK wrote: >> On 04/10/23 1:53 pm, Juan Quintela wrote: >>> Tejus GK wrote: On 03/10/23 6:14 pm, Juan Quintela wrote: > Ouch, that again. > > I think that I know how to fix that. > > Will take a look. > > Later, Juan. I first only saw that you were missing migra

Re: [PATCH v5 2/2] migration: Update error description outside migration.c

2023-10-04 Thread Juan Quintela
Tejus GK wrote: > On 04/10/23 1:53 pm, Juan Quintela wrote: >> Tejus GK wrote: >>> On 03/10/23 6:14 pm, Juan Quintela wrote: Tejus GK wrote: > A few code paths exist in the source code,where a migration is > marked as failed via MIGRATION_STATUS_FAILED, but the failure happens >

Re: [PATCH v5 2/2] migration: Update error description outside migration.c

2023-10-04 Thread Tejus GK
On 04/10/23 1:53 pm, Juan Quintela wrote: Tejus GK wrote: On 03/10/23 6:14 pm, Juan Quintela wrote: Tejus GK wrote: A few code paths exist in the source code,where a migration is marked as failed via MIGRATION_STATUS_FAILED, but the failure happens outside of migration.c In such cases, an e

Re: [PATCH v5 2/2] migration: Update error description outside migration.c

2023-10-04 Thread Juan Quintela
Tejus GK wrote: > On 03/10/23 6:14 pm, Juan Quintela wrote: >> Tejus GK wrote: >>> A few code paths exist in the source code,where a migration is >>> marked as failed via MIGRATION_STATUS_FAILED, but the failure happens >>> outside of migration.c >>> >>> In such cases, an error_report() c

Re: [PATCH v5 2/2] migration: Update error description outside migration.c

2023-10-03 Thread Tejus GK
On 03/10/23 6:14 pm, Juan Quintela wrote: Tejus GK wrote: A few code paths exist in the source code,where a migration is marked as failed via MIGRATION_STATUS_FAILED, but the failure happens outside of migration.c In such cases, an error_report() call is made, however the current MigrationStat

Re: [PATCH v5 2/2] migration: Update error description outside migration.c

2023-10-03 Thread Juan Quintela
Tejus GK wrote: > A few code paths exist in the source code,where a migration is > marked as failed via MIGRATION_STATUS_FAILED, but the failure happens > outside of migration.c > > In such cases, an error_report() call is made, however the current > MigrationState is never updat

[PATCH v5 2/2] migration: Update error description outside migration.c

2023-10-02 Thread Tejus GK
A few code paths exist in the source code,where a migration is marked as failed via MIGRATION_STATUS_FAILED, but the failure happens outside of migration.c In such cases, an error_report() call is made, however the current MigrationState is never updated with the error description, and hence clien