Re: [PATCH v5 24/36] qapi/source.py: add type hint annotations

2020-10-09 Thread John Snow
On 10/9/20 10:30 AM, John Snow wrote: On 10/8/20 4:42 AM, Markus Armbruster wrote: John Snow writes: On 10/7/20 7:55 AM, Markus Armbruster wrote: John Snow writes: Annotations do not change runtime behavior. This commit *only* adds annotations. A note on typing of __init__: mypy requires

Re: [PATCH v5 24/36] qapi/source.py: add type hint annotations

2020-10-09 Thread John Snow
On 10/8/20 4:42 AM, Markus Armbruster wrote: John Snow writes: On 10/7/20 7:55 AM, Markus Armbruster wrote: John Snow writes: Annotations do not change runtime behavior. This commit *only* adds annotations. A note on typing of __init__: mypy requires init functions with no parameters to d

Re: [PATCH v5 24/36] qapi/source.py: add type hint annotations

2020-10-08 Thread Markus Armbruster
John Snow writes: > On 10/7/20 7:55 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Annotations do not change runtime behavior. >>> This commit *only* adds annotations. >>> >>> A note on typing of __init__: mypy requires init functions with no >>> parameters to document a return type o

Re: [PATCH v5 24/36] qapi/source.py: add type hint annotations

2020-10-07 Thread John Snow
On 10/7/20 7:55 AM, Markus Armbruster wrote: John Snow writes: Annotations do not change runtime behavior. This commit *only* adds annotations. A note on typing of __init__: mypy requires init functions with no parameters to document a return type of None to be considered fully typed. In the

Re: [PATCH v5 24/36] qapi/source.py: add type hint annotations

2020-10-07 Thread Markus Armbruster
John Snow writes: > Annotations do not change runtime behavior. > This commit *only* adds annotations. > > A note on typing of __init__: mypy requires init functions with no > parameters to document a return type of None to be considered fully > typed. In the case when there are input parameters,

[PATCH v5 24/36] qapi/source.py: add type hint annotations

2020-10-05 Thread John Snow
Annotations do not change runtime behavior. This commit *only* adds annotations. A note on typing of __init__: mypy requires init functions with no parameters to document a return type of None to be considered fully typed. In the case when there are input parameters, None may be omitted. Since __