Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-07-02 Thread David Gibson
On Fri, Jul 02, 2021 at 04:55:47PM +0200, Julia Suvorova wrote: > On Thu, Jul 1, 2021 at 6:59 AM David Gibson > wrote: > > > > On Thu, Jun 17, 2021 at 09:07:35PM +0200, Julia Suvorova wrote: > > > Add acpi_pcihp to ich9_pm as part of > > > 'acpi-pci-hotplug-with-bridge-support' option. Set defaul

Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-07-02 Thread Michael S. Tsirkin
On Fri, Jul 02, 2021 at 04:55:47PM +0200, Julia Suvorova wrote: > > Doesn't this need to be protected by if (pm->use_acpi_hotplug_bridge) > > ? Otherwise pm->acpi_pci_hotplug won't be initialized. > > Yes, you're right. Although it doesn't affect anything now, it should > be fixed. I'll send a pat

Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-07-02 Thread Julia Suvorova
On Thu, Jul 1, 2021 at 6:59 AM David Gibson wrote: > > On Thu, Jun 17, 2021 at 09:07:35PM +0200, Julia Suvorova wrote: > > Add acpi_pcihp to ich9_pm as part of > > 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. > > > > Signed-off-by: Julia Suvorova > > Reviewed-by: Igor Mamm

Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-07-02 Thread Michael S. Tsirkin
On Thu, Jul 01, 2021 at 02:46:35PM +1000, David Gibson wrote: > On Thu, Jun 17, 2021 at 09:07:35PM +0200, Julia Suvorova wrote: > > Add acpi_pcihp to ich9_pm as part of > > 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. > > > > Signed-off-by: Julia Suvorova > > Reviewed-by:

Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-06-30 Thread David Gibson
On Thu, Jun 17, 2021 at 09:07:35PM +0200, Julia Suvorova wrote: > Add acpi_pcihp to ich9_pm as part of > 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > Reviewed-by: Marcel Apfelbaum > --- > hw/i386/acpi-buil

Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-06-23 Thread Marcel Apfelbaum
On Thu, Jun 17, 2021 at 10:08 PM Julia Suvorova wrote: > Add acpi_pcihp to ich9_pm as part of > 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. > > Signed-off-by: Julia Suvorova > Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.h | 1 + > include/hw/acpi/ich9.h |

[PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-06-17 Thread Julia Suvorova
Add acpi_pcihp to ich9_pm as part of 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov --- hw/i386/acpi-build.h | 1 + include/hw/acpi/ich9.h | 3 ++ hw/acpi/ich9.c | 67 +