Vladimir Sementsov-Ogievskiy writes:
> 04.12.2019 16:03, Markus Armbruster wrote:
>> Markus Armbruster writes:
>>
>>> Vladimir Sementsov-Ogievskiy writes:
>>>
29.11.2019 17:35, Markus Armbruster wrote:
>> [...]
> I pushed my fixups to git://repo.or.cz/qemu/armbru.git branch error-prep
04.12.2019 16:03, Markus Armbruster wrote:
> Markus Armbruster writes:
>
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 29.11.2019 17:35, Markus Armbruster wrote:
> [...]
I pushed my fixups to git://repo.or.cz/qemu/armbru.git branch error-prep
for your convenience. The commit messages
Markus Armbruster writes:
> Vladimir Sementsov-Ogievskiy writes:
>
>> 29.11.2019 17:35, Markus Armbruster wrote:
[...]
>>> I pushed my fixups to git://repo.or.cz/qemu/armbru.git branch error-prep
>>> for your convenience. The commit messages of the fixed up commits need
>>> rephrasing, of cours
Vladimir Sementsov-Ogievskiy writes:
> 29.11.2019 17:35, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 28.11.2019 23:29, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
> 28.11.2019 17:23, Markus Armbruster wrote:
>> Vladimir Sementsov-
Vladimir Sementsov-Ogievskiy writes:
> 28.11.2019 23:29, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 28.11.2019 17:23, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
> Error **errp is almost always OUT-argument: it's assumed to be NULL,
29.11.2019 17:35, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy writes:
>
>> 28.11.2019 23:29, Markus Armbruster wrote:
>>> Vladimir Sementsov-Ogievskiy writes:
>>>
28.11.2019 17:23, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy writes:
>
>> Error **errp is
28.11.2019 23:29, Markus Armbruster wrote:
>>> [PATCH v6] block/snapshot: rename Error ** parameter to more common
>>> errp
>>> [PATCH v6] hw/i386/amd_iommu: rename Error ** parameter to more
>>> common errp
>>> [PATCH v6] qga: rename Error ** parameter to more common errp
>>>
ERRP_AUTO_PROPAGATE, but not all. Thus, presence of
>>> ERRP_AUTO_PROPAGATE() won't be a reliable indicator of "the Error **
>>> parameter is for passing an error to the caller".
>>>
>>> * I can't see machinery to help us catch viola
machinery to help us catch violations of the convention.
>>
>>> This patch updates only error API functions. There still a few
>>> functions with errp-in semantics, they will be updated in further
>>> commits.
>>
>> Splitting the series into individu
he convention.
>
>> This patch updates only error API functions. There still a few
>> functions with errp-in semantics, they will be updated in further
>> commits.
>
> Splitting the series into individual patches was a bad idea :)
>
> First, it really needs review as a w
patch updates only error API functions. There still a few
> functions with errp-in semantics, they will be updated in further
> commits.
Splitting the series into individual patches was a bad idea :)
First, it really needs review as a whole. I'll do that, but now I have
to hunt
Error **errp is almost always OUT-argument: it's assumed to be NULL, or
pointer to NULL-initialized pointer, or pointer to error_abort or
error_fatal, for callee to report error.
But very few functions instead get Error **errp as IN-argument:
it's assumed to be set (or, maybe, NULL), and callee sh
12 matches
Mail list logo
