Il mer 7 ott 2020, 21:18 Peter Maydell ha
scritto:
> > I have no idea how to fix it. Probably it can be made to work using a
> > string argument and "shell=True", but at this point it makes more sense
> > to keep the shell script version.
>
> If you're keeping the shell script version could you
On Wed, 7 Oct 2020 at 17:43, Paolo Bonzini wrote:
> I have no idea how to fix it. Probably it can be made to work using a
> string argument and "shell=True", but at this point it makes more sense
> to keep the shell script version.
If you're keeping the shell script version could you queue
the b
On Thu, Oct 8, 2020 at 12:43 AM Paolo Bonzini wrote:
>
> On 07/10/20 18:23, 罗勇刚(Yonggang Luo) wrote:
> >> +if not pkgversion and os.path.exists('.git'):
> >> +# The quote of v* should preserve, otherwise git command
> > would fail
> >> +pc = subprocess.run(['git', 'describe', '
Patchew URL:
https://patchew.org/QEMU/20201007162138.425-1-luoyongg...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201007162138.425-1-luoyongg...@gmail.com
Subject: [PATCH v6] scripts: Convert qemu
On 07/10/20 18:23, 罗勇刚(Yonggang Luo) wrote:
>> + if not pkgversion and os.path.exists('.git'):
>> + # The quote of v* should preserve, otherwise git command
> would fail
>> + pc = subprocess.run(['git', 'describe', '--match', "'v*'",
> '--dirty', '--always'],
>> +
The sh script are harder to maintain for compatible different
xsh environment so convert it to python script
Also incorporate the fixes in
https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/
The quote of v* should preserve, otherwise git command would fail
Signed-off-by:
Hi Paolo, the qemu-version script you queued are mis removed the quote of
"'v*'", that's
would cause the building of qemu failed.
please queue this instead.
I also revised the commit message
On Thu, Oct 8, 2020 at 12:21 AM Yonggang Luo wrote:
>
> The sh script are harder to maintain for compatibl