Re: [PATCH v6 0/7] Add ARM Cortex-R52 CPU

2022-12-26 Thread Tobias Röhmel
Thanks for all the help, I learned a lot! Best regards, Tobias On 19.12.22 18:05, Peter Maydell wrote: On Tue, 6 Dec 2022 at 10:25, wrote: From: Tobias Röhmel Sorry for the "Reviewed-by" messup. I missed that on the explanation page. Thanks again for the review :) v6: patch 5: - I also ch

Re: [PATCH v6 0/7] Add ARM Cortex-R52 CPU

2022-12-19 Thread Peter Maydell
On Tue, 6 Dec 2022 at 10:25, wrote: > > From: Tobias Röhmel > > Sorry for the "Reviewed-by" messup. I missed that on the explanation > page. Thanks again for the review :) > > v6: > patch 5: > - I also changed HPRENR from ARM_CP_ALIAS to ARM_CP_NO_RAW. > Its state is also present in the HPRLAR

Re: [PATCH v6 0/7] Add ARM Cortex-R52 CPU

2022-12-06 Thread Philippe Mathieu-Daudé
On 6/12/22 12:43, Tobias Roehmel wrote: On 06.12.22 11:39, Philippe Mathieu-Daudé wrote: On 6/12/22 11:24, tobias.roeh...@rwth-aachen.de wrote: From: Tobias Röhmel v6: patch 5: - I'm freeing the PRBAR/... strings explicitly now since    I don't know how to use autofree in this setup correc

Re: [PATCH v6 0/7] Add ARM Cortex-R52 CPU

2022-12-06 Thread Tobias Roehmel
On 06.12.22 11:39, Philippe Mathieu-Daudé wrote: On 6/12/22 11:24, tobias.roeh...@rwth-aachen.de wrote: From: Tobias Röhmel v6: patch 5: - I'm freeing the PRBAR/... strings explicitly now since    I don't know how to use autofree in this setup correctly.    Maybe {} around the part were th

Re: [PATCH v6 0/7] Add ARM Cortex-R52 CPU

2022-12-06 Thread Philippe Mathieu-Daudé
On 6/12/22 11:24, tobias.roeh...@rwth-aachen.de wrote: From: Tobias Röhmel v6: patch 5: - I'm freeing the PRBAR/... strings explicitly now since I don't know how to use autofree in this setup correctly. Maybe {} around the part were the string is created/used, such that it is dropped

[PATCH v6 0/7] Add ARM Cortex-R52 CPU

2022-12-06 Thread tobias.roehmel
From: Tobias Röhmel Sorry for the "Reviewed-by" messup. I missed that on the explanation page. Thanks again for the review :) v6: patch 5: - I also changed HPRENR from ARM_CP_ALIAS to ARM_CP_NO_RAW. Its state is also present in the HPRLAR registers, but it doesn't make sense to access it raw