[PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-25 Thread Peter Maydell
This series switches all our QAPI doc comments over from texinfo format to rST. It then removes all the texinfo machinery, because this was the last user of texinfo. I think I have now resolved all of Markus' issues raised in his review of v5, and IMHO this is ready to commit. If there are still

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-25 Thread John Snow
On 9/25/20 12:22 PM, Peter Maydell wrote: * although there are HTML anchors on all the command/object/etc headings, they are not stable but just serial-number based tags like '#qapidoc-35', so not suitable for trying to link to from other parts of the docs I suppose this answers m

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-25 Thread Peter Maydell
On Fri, 25 Sep 2020 at 17:54, John Snow wrote: > > On 9/25/20 12:22 PM, Peter Maydell wrote: > > * although there are HTML anchors on all the command/object/etc > > headings, they are not stable but just serial-number based > > tags like '#qapidoc-35', so not suitable for trying to link

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-25 Thread John Snow
On 9/25/20 1:02 PM, Peter Maydell wrote: On Fri, 25 Sep 2020 at 17:54, John Snow wrote: On 9/25/20 12:22 PM, Peter Maydell wrote: * although there are HTML anchors on all the command/object/etc headings, they are not stable but just serial-number based tags like '#qapidoc-35', so

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200925162316.21205-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200925162316.21205-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-25 Thread Peter Maydell
On Fri, 25 Sep 2020 at 20:25, wrote: > In file included from ../src/qapi/qapi-schema.json:78: > ../src/qapi/migration.json:1747:1: unexpected de-indent (expected at least 13 > spaces) This is yet another mis-indented line in a change to the QAPI doc-comments (commit 4c437254b807). It hit master

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-28 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 25 Sep 2020 at 20:25, wrote: > >> In file included from ../src/qapi/qapi-schema.json:78: >> ../src/qapi/migration.json:1747:1: unexpected de-indent (expected at least >> 13 spaces) > > This is yet another mis-indented line in a change to the QAPI > doc-comments (

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-28 Thread Peter Maydell
On Mon, 28 Sep 2020 at 14:04, Markus Armbruster wrote: > > Peter Maydell writes: > > > On Fri, 25 Sep 2020 at 20:25, wrote: > > > >> In file included from ../src/qapi/qapi-schema.json:78: > >> ../src/qapi/migration.json:1747:1: unexpected de-indent (expected at least > >> 13 spaces) > > > > Thi

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-29 Thread Markus Armbruster
Peter Maydell writes: > This series switches all our QAPI doc comments over from texinfo > format to rST. It then removes all the texinfo machinery, because > this was the last user of texinfo. > > I think I have now resolved all of Markus' issues raised in his > review of v5, and IMHO this is r

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-29 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 28 Sep 2020 at 14:04, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > On Fri, 25 Sep 2020 at 20:25, wrote: >> > >> >> In file included from ../src/qapi/qapi-schema.json:78: >> >> ../src/qapi/migration.json:1747:1: unexpected de-indent (expected at

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-29 Thread Peter Maydell
On Tue, 29 Sep 2020 at 16:26, Markus Armbruster wrote: > One more issue: > > /work/armbru/qemu/docs/../qapi/machine.json:1000: WARNING: Unexpected > indentation. > /work/armbru/qemu/docs/../qapi/machine.json:1000: WARNING: Block quote > ends without a blank line; unexpected unindent. > >

Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-29 Thread Markus Armbruster
Peter Maydell writes: > This series switches all our QAPI doc comments over from texinfo > format to rST. It then removes all the texinfo machinery, because > this was the last user of texinfo. > > I think I have now resolved all of Markus' issues raised in his > review of v5, and IMHO this is r