Re: [PATCH v6 09/10] migration/yank: Keep track of registered yank instances

2023-09-25 Thread Lukas Straub
On Mon, 25 Sep 2023 09:20:58 -0300 Fabiano Rosas wrote: > CC: Daniel for the QIOChannel discussion > > Lukas Straub writes: > > On Thu, 14 Sep 2023 10:57:47 -0400 > > Peter Xu wrote: > > > >> On Thu, Sep 14, 2023 at 10:23:38AM -0300, Fabiano Rosas wrote: > >> > Peter Xu writes: > >> >

Re: [PATCH v6 09/10] migration/yank: Keep track of registered yank instances

2023-09-25 Thread Fabiano Rosas
CC: Daniel for the QIOChannel discussion Lukas Straub writes: > On Thu, 14 Sep 2023 10:57:47 -0400 > Peter Xu wrote: > >> On Thu, Sep 14, 2023 at 10:23:38AM -0300, Fabiano Rosas wrote: >> > Peter Xu writes: >> > >> > > On Wed, Sep 13, 2023 at 06:53:20PM -0300, Fabiano Rosas wrote: >> > >>

Re: [PATCH v6 09/10] migration/yank: Keep track of registered yank instances

2023-09-25 Thread Lukas Straub
On Thu, 14 Sep 2023 10:57:47 -0400 Peter Xu wrote: > On Thu, Sep 14, 2023 at 10:23:38AM -0300, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > On Wed, Sep 13, 2023 at 06:53:20PM -0300, Fabiano Rosas wrote: > > >> Peter Xu writes: > > >> > > >> > On Mon, Sep 11, 2023 at 02:13:19PM -0

Re: [PATCH v6 09/10] migration/yank: Keep track of registered yank instances

2023-09-14 Thread Peter Xu
On Thu, Sep 14, 2023 at 10:23:38AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Wed, Sep 13, 2023 at 06:53:20PM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Mon, Sep 11, 2023 at 02:13:19PM -0300, Fabiano Rosas wrote: > >> >> The core yank code is strict about bala

Re: [PATCH v6 09/10] migration/yank: Keep track of registered yank instances

2023-09-14 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Sep 13, 2023 at 06:53:20PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Mon, Sep 11, 2023 at 02:13:19PM -0300, Fabiano Rosas wrote: >> >> The core yank code is strict about balanced registering and >> >> unregistering of yank functions. >> >> >> >> This

Re: [PATCH v6 09/10] migration/yank: Keep track of registered yank instances

2023-09-13 Thread Peter Xu
On Wed, Sep 13, 2023 at 06:53:20PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Sep 11, 2023 at 02:13:19PM -0300, Fabiano Rosas wrote: > >> The core yank code is strict about balanced registering and > >> unregistering of yank functions. > >> > >> This creates a difficulty becaus

Re: [PATCH v6 09/10] migration/yank: Keep track of registered yank instances

2023-09-13 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Sep 11, 2023 at 02:13:19PM -0300, Fabiano Rosas wrote: >> The core yank code is strict about balanced registering and >> unregistering of yank functions. >> >> This creates a difficulty because the migration code registers one >> yank function per QIOChannel, but each

Re: [PATCH v6 09/10] migration/yank: Keep track of registered yank instances

2023-09-13 Thread Peter Xu
On Mon, Sep 11, 2023 at 02:13:19PM -0300, Fabiano Rosas wrote: > The core yank code is strict about balanced registering and > unregistering of yank functions. > > This creates a difficulty because the migration code registers one > yank function per QIOChannel, but each QIOChannel can be referenc

[PATCH v6 09/10] migration/yank: Keep track of registered yank instances

2023-09-11 Thread Fabiano Rosas
The core yank code is strict about balanced registering and unregistering of yank functions. This creates a difficulty because the migration code registers one yank function per QIOChannel, but each QIOChannel can be referenced by more than one QEMUFile. The yank function should not be removed unt