Re: [PATCH v6 09/14] target/arm: Don't shift attrs in get_phys_addr_lpae

2022-10-24 Thread Philippe Mathieu-Daudé
On 24/10/22 07:18, Richard Henderson wrote: Leave the upper and lower attributes in the place they originate from in the descriptor. Shifting them around is confusing, since one cannot read the bit numbers out of the manual. Also, new attributes have been added which would alter the shifts.

[PATCH v6 09/14] target/arm: Don't shift attrs in get_phys_addr_lpae

2022-10-23 Thread Richard Henderson
Leave the upper and lower attributes in the place they originate from in the descriptor. Shifting them around is confusing, since one cannot read the bit numbers out of the manual. Also, new attributes have been added which would alter the shifts. Reviewed-by: Peter Maydell Signed-off-by: