Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-02 Thread Yonggang Luo
gotcha On Sat, Oct 3, 2020 at 1:49 AM Paolo Bonzini wrote: > > On 02/10/20 19:47, 罗勇刚(Yonggang Luo) wrote: > > Because the configure script change far more complicated than you > > imgaine. And I post that before > > Daniel is literally asking for a two-line change: > > diff --git a/configure b/co

Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-02 Thread Paolo Bonzini
On 02/10/20 18:42, Daniel P. Berrangé wrote: > I don't see why the configure change has any dependancy on meson 0.56. > It just requires you to remove the mentioned header file and function > from the configure check. This patch needs to include that or it is > incomplete IMHO I agree, moving the

Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-02 Thread Paolo Bonzini
On 02/10/20 19:47, 罗勇刚(Yonggang Luo) wrote: > Because the configure script change far more complicated than you > imgaine. And I post that before Daniel is literally asking for a two-line change: diff --git a/configure b/configure index fee5faa054..ffd72b571d 100755 --- a/configure +++ b/configur

Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-02 Thread Yonggang Luo
On Sat, Oct 3, 2020 at 12:42 AM Daniel P. Berrangé wrote: > > On Sat, Oct 03, 2020 at 12:38:50AM +0800, 罗勇刚(Yonggang Luo) wrote: > > On Fri, Oct 2, 2020 at 11:36 PM Daniel P. Berrangé > > wrote: > > > > > > On Fri, Oct 02, 2020 at 01:32:28AM +0800, Yonggang Luo wrote: > > > > msys2/mingw lacks th

Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-02 Thread Daniel P . Berrangé
On Sat, Oct 03, 2020 at 12:38:50AM +0800, 罗勇刚(Yonggang Luo) wrote: > On Fri, Oct 2, 2020 at 11:36 PM Daniel P. Berrangé > wrote: > > > > On Fri, Oct 02, 2020 at 01:32:28AM +0800, Yonggang Luo wrote: > > > msys2/mingw lacks the POSIX-required langinfo.h. > > > > > > gcc test.c -DNCURSES_WIDECHAR -I

Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-02 Thread Yonggang Luo
On Fri, Oct 2, 2020 at 11:36 PM Daniel P. Berrangé wrote: > > On Fri, Oct 02, 2020 at 01:32:28AM +0800, Yonggang Luo wrote: > > msys2/mingw lacks the POSIX-required langinfo.h. > > > > gcc test.c -DNCURSES_WIDECHAR -I/mingw64/include/ncursesw -pipe -lncursesw -lgnurx -ltre -lintl -liconv > > test.

Re: [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-02 Thread Daniel P . Berrangé
On Fri, Oct 02, 2020 at 01:32:28AM +0800, Yonggang Luo wrote: > msys2/mingw lacks the POSIX-required langinfo.h. > > gcc test.c -DNCURSES_WIDECHAR -I/mingw64/include/ncursesw -pipe -lncursesw > -lgnurx -ltre -lintl -liconv > test.c:4:10: fatal error: langinfo.h: No such file or directory > 4

[PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-01 Thread Yonggang Luo
msys2/mingw lacks the POSIX-required langinfo.h. gcc test.c -DNCURSES_WIDECHAR -I/mingw64/include/ncursesw -pipe -lncursesw -lgnurx -ltre -lintl -liconv test.c:4:10: fatal error: langinfo.h: No such file or directory 4 | #include | ^~~~ compilation terminated. So we u