Re: [PATCH v7 08/14] block/qcow2: qcow2_get_specific_info(): drop error propagation

2021-02-12 Thread Eric Blake
On 2/5/21 5:52 AM, Vladimir Sementsov-Ogievskiy wrote: > 05.02.2021 14:43, Alberto Garcia wrote: >> On Tue 02 Feb 2021 01:49:50 PM CET, Vladimir Sementsov-Ogievskiy wrote: >>> -Qcow2BitmapInfoList *qcow2_get_bitmap_info_list(BlockDriverState *bs, >>> -   

Re: [PATCH v7 08/14] block/qcow2: qcow2_get_specific_info(): drop error propagation

2021-02-05 Thread Alberto Garcia
On Fri 05 Feb 2021 12:52:03 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> However the new code only uses and updates 'info_list' and it does not >> keep the head anywhere, so what the caller gets is a pointer to the >> tail. >> > > No. *info_list is modified only on the first loop iteration. And

Re: [PATCH v7 08/14] block/qcow2: qcow2_get_specific_info(): drop error propagation

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
05.02.2021 14:43, Alberto Garcia wrote: On Tue 02 Feb 2021 01:49:50 PM CET, Vladimir Sementsov-Ogievskiy wrote: -Qcow2BitmapInfoList *qcow2_get_bitmap_info_list(BlockDriverState *bs, -Error **errp) +bool qcow2_get_bitmap_info_list(BlockDriverState

Re: [PATCH v7 08/14] block/qcow2: qcow2_get_specific_info(): drop error propagation

2021-02-05 Thread Alberto Garcia
On Tue 02 Feb 2021 01:49:50 PM CET, Vladimir Sementsov-Ogievskiy wrote: > -Qcow2BitmapInfoList *qcow2_get_bitmap_info_list(BlockDriverState *bs, > -Error **errp) > +bool qcow2_get_bitmap_info_list(BlockDriverState *bs, > +

[PATCH v7 08/14] block/qcow2: qcow2_get_specific_info(): drop error propagation

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
Don't use error propagation in qcow2_get_specific_info(). For this refactor qcow2_get_bitmap_info_list, its current interface is rather weird. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h| 4 ++-- block/qcow2-bitmap.c | 26 +- block/qcow2.c