Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-25 Thread Zhao Liu
Hi Xiaoyao, > > > > generic cluster just means the cluster of processors, i.e, a group of > > > > cpus/lps. It is just a middle level between die and core. > > > > > > Not sure if you mean the "cluster" device for TCG GDB? "cluster" device > > > is different with "cluster" option in -smp. > > >

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-18 Thread Zhao Liu
On Wed, Jan 17, 2024 at 12:40:12AM +0800, Xiaoyao Li wrote: > Date: Wed, 17 Jan 2024 00:40:12 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU > > On 1/15/2024 11:18 PM, Zhao Liu wrote: > > Hi Xiaoyao, > > > > O

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-16 Thread Xiaoyao Li
On 1/15/2024 11:18 PM, Zhao Liu wrote: Hi Xiaoyao, On Mon, Jan 15, 2024 at 03:45:58PM +0800, Xiaoyao Li wrote: Date: Mon, 15 Jan 2024 15:45:58 +0800 From: Xiaoyao Li Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU On 1/15/2024 1:59 PM, Zhao Liu wrote: (Also cc

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-15 Thread Zhao Liu
Hi Xiaoyao, On Mon, Jan 15, 2024 at 03:45:58PM +0800, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 15:45:58 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU > > On 1/15/2024 1:59 PM, Zhao Liu wrote: > > (Also cc "

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-14 Thread Xiaoyao Li
On 1/15/2024 1:59 PM, Zhao Liu wrote: (Also cc "machine core" maintainers.) Hi Xiaoyao, On Mon, Jan 15, 2024 at 12:18:17PM +0800, Xiaoyao Li wrote: Date: Mon, 15 Jan 2024 12:18:17 +0800 From: Xiaoyao Li Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU On 1/

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-14 Thread Zhao Liu
(Also cc "machine core" maintainers.) Hi Xiaoyao, On Mon, Jan 15, 2024 at 12:18:17PM +0800, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 12:18:17 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU > > On 1/15/2024

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-14 Thread Xiaoyao Li
On 1/15/2024 11:27 AM, Zhao Liu wrote: On Sun, Jan 14, 2024 at 09:49:18PM +0800, Xiaoyao Li wrote: Date: Sun, 14 Jan 2024 21:49:18 +0800 From: Xiaoyao Li Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU On 1/8/2024 4:27 PM, Zhao Liu wrote: From: Zhuocheng Ding

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-14 Thread Zhao Liu
On Sun, Jan 14, 2024 at 09:49:18PM +0800, Xiaoyao Li wrote: > Date: Sun, 14 Jan 2024 21:49:18 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU > > On 1/8/2024 4:27 PM, Zhao Liu wrote: > > From: Zhuocheng Ding > > >

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-14 Thread Xiaoyao Li
On 1/8/2024 4:27 PM, Zhao Liu wrote: From: Zhuocheng Ding Introduce cluster-id other than module-id to be consistent with CpuInstanceProperties.cluster-id, and this avoids the confusion of parameter names when hotplugging. I don't think reusing 'cluster' from arm for x86's 'module' is a good

[PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-08 Thread Zhao Liu
From: Zhuocheng Ding Introduce cluster-id other than module-id to be consistent with CpuInstanceProperties.cluster-id, and this avoids the confusion of parameter names when hotplugging. Following the legacy smp check rules, also add the cluster_id validity into x86_cpu_pre_plug().