Re: [PATCH v7 27/51] i386/xen: Add support for Xen event channel delivery to vCPU

2023-01-17 Thread Paul Durrant
On 17/01/2023 12:31, David Woodhouse wrote: On Tue, 2023-01-17 at 11:11 +, Paul Durrant wrote: Ick. Do we really want cross-block gotos? For me it would look a lot nicer if you did a forward jump here and later and put the label+code after the `return 0`. How's this? From my PoV, much

Re: [PATCH v7 27/51] i386/xen: Add support for Xen event channel delivery to vCPU

2023-01-17 Thread David Woodhouse
On Tue, 2023-01-17 at 11:11 +, Paul Durrant wrote: > > Ick. Do we really want cross-block gotos? For me it would look a lot > nicer if you did a forward jump here and later and put the label+code > after the `return 0`. How's this? static int set_vcpu_info(CPUState *cs, uint64_t gpa) {

Re: [PATCH v7 27/51] i386/xen: Add support for Xen event channel delivery to vCPU

2023-01-17 Thread Paul Durrant
On 16/01/2023 21:57, David Woodhouse wrote: From: David Woodhouse The kvm_xen_inject_vcpu_callback_vector() function will either deliver the per-vCPU local APIC vector (as an MSI), or just kick the vCPU out of the kernel to trigger KVM's automatic delivery of the global vector. Support for

Re: [PATCH v7 27/51] i386/xen: Add support for Xen event channel delivery to vCPU

2023-01-17 Thread Paul Durrant
On 16/01/2023 21:57, David Woodhouse wrote: From: David Woodhouse The kvm_xen_inject_vcpu_callback_vector() function will either deliver the per-vCPU local APIC vector (as an MSI), or just kick the vCPU out of the kernel to trigger KVM's automatic delivery of the global vector. Support for

[PATCH v7 27/51] i386/xen: Add support for Xen event channel delivery to vCPU

2023-01-16 Thread David Woodhouse
From: David Woodhouse The kvm_xen_inject_vcpu_callback_vector() function will either deliver the per-vCPU local APIC vector (as an MSI), or just kick the vCPU out of the kernel to trigger KVM's automatic delivery of the global vector. Support for asserting the GSI/PCI_INTX callbacks will come