Re: [PATCH v7 38/51] i386/xen: add monitor commands to test event injection

2023-01-19 Thread David Woodhouse
On Tue, 2023-01-17 at 11:08 +0100, Markus Armbruster wrote: > > > +# Since: x.xx > > "Since: 8.0.0" (with any luck).  More of the same below. Speaking of which... I guess this first series probably wants to be considered as KVM and merged via Paolo? Or at least as far as #27/51 'i386/xen: Add

Re: [PATCH v7 38/51] i386/xen: add monitor commands to test event injection

2023-01-17 Thread David Woodhouse
Incremental patch, which I think addresses everything major? Would still be nice to make the remote-domain field optional. I *still* assume p->type is in the valid range, but at least if that's wrong now it'll just put a bad value in the enum instead of crashing ;) (In fact as I squash this I'll

Re: [PATCH v7 38/51] i386/xen: add monitor commands to test event injection

2023-01-17 Thread David Woodhouse
Hi Markus, thanks for the review. On Tue, 2023-01-17 at 11:08 +0100, Markus Armbrster wrote: > David Woodhouse writes: > > @@ -1059,3 +1063,137 @@ int xen_evtchn_send_op(struct evtchn_send *send) > > return ret; > >  } > >   > > +static const char *type_names[] = { > > +    "closed", > > +  

Re: [PATCH v7 38/51] i386/xen: add monitor commands to test event injection

2023-01-17 Thread Markus Armbruster
David Woodhouse writes: > From: Joao Martins > > Specifically add listing, injection of event channels. > > Signed-off-by: Joao Martins > Signed-off-by: David Woodhouse > Acked-by: Dr. David Alan Gilbert > --- > hmp-commands.hx | 29 > hw/i386/kvm/meson.build | 4 ++ >

[PATCH v7 38/51] i386/xen: add monitor commands to test event injection

2023-01-16 Thread David Woodhouse
From: Joao Martins Specifically add listing, injection of event channels. Signed-off-by: Joao Martins Signed-off-by: David Woodhouse Acked-by: Dr. David Alan Gilbert --- hmp-commands.hx | 29 hw/i386/kvm/meson.build | 4 ++ hw/i386/kvm/xen-stubs.c | 25 +++