Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-30 Thread Paolo Bonzini
On 30/09/19 12:04, Christian Borntraeger wrote: > Paolo, ok it I pick the first 3 patches as well? Can you ack? Yes, please. Acked-by: Paolo Bonzini Paolo

Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-30 Thread Christian Borntraeger
On 30.09.19 11:33, Igor Mammedov wrote: > On Mon, 30 Sep 2019 09:09:59 +0200 > Christian Borntraeger wrote: > >> On 28.09.19 03:28, Peter Xu wrote: >>> On Fri, Sep 27, 2019 at 03:33:20PM +0200, Igor Mammedov wrote: On Thu, 26 Sep 2019 07:52:35 +0800 Peter Xu wrote: >

Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-30 Thread Igor Mammedov
On Mon, 30 Sep 2019 09:09:59 +0200 Christian Borntraeger wrote: > On 28.09.19 03:28, Peter Xu wrote: > > On Fri, Sep 27, 2019 at 03:33:20PM +0200, Igor Mammedov wrote: > >> On Thu, 26 Sep 2019 07:52:35 +0800 > >> Peter Xu wrote: > >> > >>> On Wed, Sep 25, 2019 at 01:51:05PM +0200, Igor

Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-30 Thread Christian Borntraeger
On 28.09.19 03:28, Peter Xu wrote: > On Fri, Sep 27, 2019 at 03:33:20PM +0200, Igor Mammedov wrote: >> On Thu, 26 Sep 2019 07:52:35 +0800 >> Peter Xu wrote: >> >>> On Wed, Sep 25, 2019 at 01:51:05PM +0200, Igor Mammedov wrote: On Wed, 25 Sep 2019 11:27:00 +0800 Peter Xu wrote:

Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-27 Thread Peter Xu
On Fri, Sep 27, 2019 at 03:33:20PM +0200, Igor Mammedov wrote: > On Thu, 26 Sep 2019 07:52:35 +0800 > Peter Xu wrote: > > > On Wed, Sep 25, 2019 at 01:51:05PM +0200, Igor Mammedov wrote: > > > On Wed, 25 Sep 2019 11:27:00 +0800 > > > Peter Xu wrote: > > > > > > > On Tue, Sep 24, 2019 at

Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-27 Thread Igor Mammedov
On Thu, 26 Sep 2019 07:52:35 +0800 Peter Xu wrote: > On Wed, Sep 25, 2019 at 01:51:05PM +0200, Igor Mammedov wrote: > > On Wed, 25 Sep 2019 11:27:00 +0800 > > Peter Xu wrote: > > > > > On Tue, Sep 24, 2019 at 10:47:51AM -0400, Igor Mammedov wrote: > > > > s390 was trying to solve limited

Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-25 Thread Peter Xu
On Wed, Sep 25, 2019 at 01:51:05PM +0200, Igor Mammedov wrote: > On Wed, 25 Sep 2019 11:27:00 +0800 > Peter Xu wrote: > > > On Tue, Sep 24, 2019 at 10:47:51AM -0400, Igor Mammedov wrote: > > > s390 was trying to solve limited KVM memslot size issue by abusing > > >

Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-25 Thread Igor Mammedov
On Wed, 25 Sep 2019 11:27:00 +0800 Peter Xu wrote: > On Tue, Sep 24, 2019 at 10:47:51AM -0400, Igor Mammedov wrote: > > s390 was trying to solve limited KVM memslot size issue by abusing > > memory_region_allocate_system_memory(), which breaks API contract > > where the function might be called

Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-24 Thread Peter Xu
On Tue, Sep 24, 2019 at 10:47:51AM -0400, Igor Mammedov wrote: > s390 was trying to solve limited KVM memslot size issue by abusing > memory_region_allocate_system_memory(), which breaks API contract > where the function might be called only once. > > Beside an invalid use of API, the approach

[PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-24 Thread Igor Mammedov
s390 was trying to solve limited KVM memslot size issue by abusing memory_region_allocate_system_memory(), which breaks API contract where the function might be called only once. Beside an invalid use of API, the approach also introduced migration issue, since RAM chunks for each