Re: [PATCH v8 00/12] Add VIRTIO sound card

2023-09-06 Thread Matias Ezequiel Vara Larsen
On Mon, Aug 28, 2023 at 10:54:57PM +0300, Emmanouil Pitsidianakis wrote: > This patch series adds an audio device implementing the recent virtio > sound spec (1.2) and a corresponding PCI wrapper device. > > v8 can be found online at: > > https://gitlab.com/epilys/qemu/-/tree/virtio-snd-v8 >

Re: [PATCH v8 00/12] Add VIRTIO sound card

2023-09-05 Thread Volker Rümelin
Am 04.09.23 um 12:01 schrieb Manos Pitsidianakis: Hello Volker :) On Mon, 04 Sep 2023 10:20, Volker Rümelin wrote: All qemu_log_mask() format strings need a trailing \n. Thank you, will fix it! I still hear a lot of playback dropouts. I had planned to look at the playback code, but I

Re: [PATCH v8 00/12] Add VIRTIO sound card

2023-09-05 Thread Volker Rümelin
Am 04.09.23 um 14:11 schrieb Alex Bennée: Manos Pitsidianakis writes: Hello Volker :) On Mon, 04 Sep 2023 10:20, Volker Rümelin wrote: All qemu_log_mask() format strings need a trailing \n. Thank you, will fix it! I still hear a lot of playback dropouts. I had planned to look at the

Re: [PATCH v8 00/12] Add VIRTIO sound card

2023-09-04 Thread Alex Bennée
Manos Pitsidianakis writes: > Hello Volker :) > > On Mon, 04 Sep 2023 10:20, Volker Rümelin wrote: >>All qemu_log_mask() format strings need a trailing \n. > > Thank you, will fix it! > >> I still hear a lot of playback dropouts. I had planned to look at >> the playback code, but I didn't

Re: [PATCH v8 00/12] Add VIRTIO sound card

2023-09-04 Thread Manos Pitsidianakis
Hello Volker :) On Mon, 04 Sep 2023 10:20, Volker Rümelin wrote: All qemu_log_mask() format strings need a trailing \n. Thank you, will fix it! I still hear a lot of playback dropouts. I had planned to look at the playback code, but I didn't have the time until now. Compared to v6 audio

Re: [PATCH v8 00/12] Add VIRTIO sound card

2023-09-04 Thread Volker Rümelin
Am 28.08.23 um 21:54 schrieb Emmanouil Pitsidianakis: This patch series adds an audio device implementing the recent virtio sound spec (1.2) and a corresponding PCI wrapper device. Hi Manos, I have a few more general comments. All qemu_log_mask() format strings need a trailing \n. I still

Re: [PATCH v8 00/12] Add VIRTIO sound card

2023-08-30 Thread Alex Bennée
Emmanouil Pitsidianakis writes: > This patch series adds an audio device implementing the recent virtio > sound spec (1.2) and a corresponding PCI wrapper device. And you can have a: Tested-by: Alex Bennée for the whole series. mst, are you going to pull via your tree? -- Alex Bennée

[PATCH v8 00/12] Add VIRTIO sound card

2023-08-28 Thread Emmanouil Pitsidianakis
This patch series adds an audio device implementing the recent virtio sound spec (1.2) and a corresponding PCI wrapper device. v8 can be found online at: https://gitlab.com/epilys/qemu/-/tree/virtio-snd-v8 Ref 69eb5f4fbae731f5fc05dea8a5f4b656e0de127f Main differences with v7 patch series