Re: [PATCH v8 06/10] hw/fsi: Aspeed APB2OPB interface

2024-01-09 Thread Ninad Palsule
Hello Cedric, +    for (i = 0; i < ASPEED_FSI_NUM; i++) { +    if (!qdev_realize_and_unref(DEVICE(>fsi[i]), BUS(>opb[i]), s->fsi[i] is not allocated. We should use qdev_realize instead. I am not sure I understood this. FSIMasterState fsi[ASPEED_FSI_NUM]; is inside structure

Re: [PATCH v8 06/10] hw/fsi: Aspeed APB2OPB interface

2024-01-08 Thread Cédric Le Goater
Hello Ninad, +static void fsi_aspeed_apb2opb_realize(DeviceState *dev, Error **errp) +{ +    SysBusDevice *sbd = SYS_BUS_DEVICE(dev); +    AspeedAPB2OPBState *s = ASPEED_APB2OPB(dev); +    int i; + +    sysbus_init_irq(sbd, >irq); + +    memory_region_init_io(>iomem, OBJECT(s), _apb2opb_ops, s,

Re: [PATCH v8 06/10] hw/fsi: Aspeed APB2OPB interface

2024-01-08 Thread Ninad Palsule
Hello Cedric, On 12/12/23 08:49, Cédric Le Goater wrote: On 11/29/23 00:56, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. An APB-to-OPB bridge enabling access to the OPB from the ARM core in the AST2600. Hardware limitations prevent the

Re: [PATCH v8 06/10] hw/fsi: Aspeed APB2OPB interface

2023-12-12 Thread Cédric Le Goater
On 11/29/23 00:56, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. An APB-to-OPB bridge enabling access to the OPB from the ARM core in the AST2600. Hardware limitations prevent the OPB from being directly mapped into APB, so all accesses

[PATCH v8 06/10] hw/fsi: Aspeed APB2OPB interface

2023-11-28 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. An APB-to-OPB bridge enabling access to the OPB from the ARM core in the AST2600. Hardware limitations prevent the OPB from being directly mapped into APB, so all accesses are indirect through the bridge.