Re: [PATCH v8 06/10] target/ppc: enable PMU instruction count

2021-12-01 Thread David Gibson
On Wed, Dec 01, 2021 at 10:12:27AM -0300, Daniel Henrique Barboza wrote: > On 11/30/21 20:52, David Gibson wrote: > > On Tue, Nov 30, 2021 at 07:24:04PM -0300, Daniel Henrique Barboza wrote: [snip] > > > > > +static bool pmu_increment_insns(CPUPPCState *env, uint32_t num_insns) > > > > > +{ > > > >

Re: [PATCH v8 06/10] target/ppc: enable PMU instruction count

2021-12-01 Thread Daniel Henrique Barboza
On 11/30/21 20:52, David Gibson wrote: On Tue, Nov 30, 2021 at 07:24:04PM -0300, Daniel Henrique Barboza wrote: On 11/29/21 01:36, David Gibson wrote: On Thu, Nov 25, 2021 at 12:08:13PM -0300, Daniel Henrique Barboza wrote: The PMU is already counting cycles by calculating time elapsed in

Re: [PATCH v8 06/10] target/ppc: enable PMU instruction count

2021-11-30 Thread David Gibson
On Tue, Nov 30, 2021 at 07:24:04PM -0300, Daniel Henrique Barboza wrote: > > > On 11/29/21 01:36, David Gibson wrote: > > On Thu, Nov 25, 2021 at 12:08:13PM -0300, Daniel Henrique Barboza wrote: > > > The PMU is already counting cycles by calculating time elapsed in > > > nanoseconds. Counting in

Re: [PATCH v8 06/10] target/ppc: enable PMU instruction count

2021-11-30 Thread Daniel Henrique Barboza
On 11/29/21 01:36, David Gibson wrote: On Thu, Nov 25, 2021 at 12:08:13PM -0300, Daniel Henrique Barboza wrote: The PMU is already counting cycles by calculating time elapsed in nanoseconds. Counting instructions is a different matter and requires another approach. This patch adds the capabi

Re: [PATCH v8 06/10] target/ppc: enable PMU instruction count

2021-11-28 Thread David Gibson
On Thu, Nov 25, 2021 at 12:08:13PM -0300, Daniel Henrique Barboza wrote: > The PMU is already counting cycles by calculating time elapsed in > nanoseconds. Counting instructions is a different matter and requires > another approach. > > This patch adds the capability of counting completed instruct

[PATCH v8 06/10] target/ppc: enable PMU instruction count

2021-11-25 Thread Daniel Henrique Barboza
The PMU is already counting cycles by calculating time elapsed in nanoseconds. Counting instructions is a different matter and requires another approach. This patch adds the capability of counting completed instructions (Perf event PM_INST_CMPL) by counting the amount of instructions translated in