Re: [PATCH v8 1/9] machine: Use error handling when CPU type is checked

2023-11-30 Thread Gavin Shan
Hi Markus, On 11/29/23 19:20, Markus Armbruster wrote: Gavin Shan writes: QEMU will be terminated if the specified CPU type isn't supported in machine_run_board_init(). The list of supported CPU type names is tracked by mc->valid_cpu_types. Suggest to drop the second sentence. Indeed, it

Re: [PATCH v8 1/9] machine: Use error handling when CPU type is checked

2023-11-29 Thread Markus Armbruster
Gavin Shan writes: > QEMU will be terminated if the specified CPU type isn't supported > in machine_run_board_init(). The list of supported CPU type names > is tracked by mc->valid_cpu_types. Suggest to drop the second sentence. > The error handling can be used to propagate error messages, to b

[PATCH v8 1/9] machine: Use error handling when CPU type is checked

2023-11-28 Thread Gavin Shan
QEMU will be terminated if the specified CPU type isn't supported in machine_run_board_init(). The list of supported CPU type names is tracked by mc->valid_cpu_types. The error handling can be used to propagate error messages, to be consistent how the errors are handled for other situations in the