Re: [PATCH vRESEND] virtio/virtio-balloon: Prefer Object* over void* parameter

2022-03-18 Thread Laurent Vivier
Le 04/03/2022 à 11:20, Michael S. Tsirkin a écrit : On Tue, Mar 01, 2022 at 11:23:01PM +0100, Bernhard Beschow wrote: *opaque is an alias to *obj. Using the ladder makes the code consistent with with other devices, e.g. accel/kvm/kvm-all and accel/tcg/tcg-all. It also makes the cast more typesaf

Re: [PATCH vRESEND] virtio/virtio-balloon: Prefer Object* over void* parameter

2022-03-04 Thread Michael S. Tsirkin
On Tue, Mar 01, 2022 at 11:23:01PM +0100, Bernhard Beschow wrote: > *opaque is an alias to *obj. Using the ladder makes the code consistent with > with other devices, e.g. accel/kvm/kvm-all and accel/tcg/tcg-all. It also > makes the cast more typesafe. > > Signed-off-by: Bernhard Beschow > Review

[PATCH vRESEND] virtio/virtio-balloon: Prefer Object* over void* parameter

2022-03-01 Thread Bernhard Beschow
*opaque is an alias to *obj. Using the ladder makes the code consistent with with other devices, e.g. accel/kvm/kvm-all and accel/tcg/tcg-all. It also makes the cast more typesafe. Signed-off-by: Bernhard Beschow Reviewed-by: David Hildenbrand --- hw/virtio/virtio-balloon.c | 10 +- 1 f