On Tue, May 04, 2021 at 08:29:50AM +0200, Pankaj Gupta wrote:
> +CC Danpb
>
> > >>> Marc-André, I'd like your opinion for this one, in particular the use of
> > >>> g_source_remove().
> > >>>
> > >>
> > >> My opinion isn't really worth much, my review would have a bit more
> > >> value.
> > >>
>
+CC Danpb
> >>> Marc-André, I'd like your opinion for this one, in particular the use of
> >>> g_source_remove().
> >>>
> >>
> >> My opinion isn't really worth much, my review would have a bit more value.
> >>
> >> GSource has indeed some peculiar lifetime management, that I got wrong in
> >> the
On Sat, Apr 17, 2021 at 10:02 AM Markus Armbruster wrote:
>
> Marc-André Lureau writes:
>
> > Hi
> >
> > On Fri, Apr 16, 2021 at 6:59 PM Marc-André Lureau <
> > marcandre.lur...@gmail.com> wrote:
> >
> >> Hi
> >>
> >> On Fri, Apr 16, 2021 at 6:51 PM Markus Armbruster
> >> wrote:
> >>
> >>> Marc-
Li Zhang writes:
> On Fri, Apr 16, 2021 at 4:50 PM Markus Armbruster wrote:
[...]
>> As I wrote in my review of v1, this function copies from
>> monitor_data_init(), monitor_init_qmp(), and monitor_flush_locked().
>> Feels like a refactoring would be in order. Doing it on top might be
>> easi
Marc-André Lureau writes:
> Hi
>
> On Fri, Apr 16, 2021 at 6:59 PM Marc-André Lureau <
> marcandre.lur...@gmail.com> wrote:
>
>> Hi
>>
>> On Fri, Apr 16, 2021 at 6:51 PM Markus Armbruster
>> wrote:
>>
>>> Marc-André, I'd like your opinion for this one, in particular the use of
>>> g_source_remov
Hi Marc-André,
On Fri, Apr 16, 2021 at 5:28 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Fri, Apr 16, 2021 at 6:59 PM Marc-André Lureau
> wrote:
>>
>> Hi
>>
>> On Fri, Apr 16, 2021 at 6:51 PM Markus Armbruster wrote:
>>>
>>> Marc-André, I'd like your opinion for this one, in particular the use of
Hi
On Fri, Apr 16, 2021 at 6:59 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Fri, Apr 16, 2021 at 6:51 PM Markus Armbruster
> wrote:
>
>> Marc-André, I'd like your opinion for this one, in particular the use of
>> g_source_remove().
>>
>
> My opinion isn't really worth m
On Fri, Apr 16, 2021 at 4:50 PM Markus Armbruster wrote:
>
> Marc-André, I'd like your opinion for this one, in particular the use of
> g_source_remove().
>
> Li Zhang writes:
>
> > For some scenarios, it needs to hot-add a monitor device.
> > But QEMU doesn't support hotplug yet. It also works b
Hi
On Fri, Apr 16, 2021 at 6:51 PM Markus Armbruster wrote:
> Marc-André, I'd like your opinion for this one, in particular the use of
> g_source_remove().
>
My opinion isn't really worth much, my review would have a bit more value.
GSource has indeed some peculiar lifetime management, that I
Marc-André, I'd like your opinion for this one, in particular the use of
g_source_remove().
Li Zhang writes:
> For some scenarios, it needs to hot-add a monitor device.
> But QEMU doesn't support hotplug yet. It also works by adding
> a monitor with null backend by default and then change its
>
Ping
On Tue, Apr 13, 2021 at 11:37 PM Li Zhang wrote:
>
> For some scenarios, it needs to hot-add a monitor device.
> But QEMU doesn't support hotplug yet. It also works by adding
> a monitor with null backend by default and then change its
> backend to socket by QMP command "chardev-change".
>
>
For some scenarios, it needs to hot-add a monitor device.
But QEMU doesn't support hotplug yet. It also works by adding
a monitor with null backend by default and then change its
backend to socket by QMP command "chardev-change".
So this patch is to support monitor chardev hotswap with QMP.
Signe
12 matches
Mail list logo
