Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-07-08 Thread Yoshinori Sato
2020-07-08 00:06 に Thomas Huth さんは書きました: On 07/07/2020 17.02, Yoshinori Sato wrote: On Mon, 29 Jun 2020 18:58:56 +0900, Philippe Mathieu-Daudé wrote: Hi Yoshinori, On 6/25/20 11:25 AM, Peter Maydell wrote: On Sun, 21 Jun 2020 at 13:54, Philippe Mathieu-Daudé wrote: From: Yoshinori Sato

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-07-07 Thread Thomas Huth
On 07/07/2020 17.02, Yoshinori Sato wrote: > On Mon, 29 Jun 2020 18:58:56 +0900, > Philippe Mathieu-Daudé wrote: >> >> Hi Yoshinori, >> >> On 6/25/20 11:25 AM, Peter Maydell wrote: >>> On Sun, 21 Jun 2020 at 13:54, Philippe Mathieu-Daudé >>> wrote: From: Yoshinori Sato renesa

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-07-07 Thread Philippe Mathieu-Daudé
On 7/7/20 5:02 PM, Yoshinori Sato wrote: > On Mon, 29 Jun 2020 18:58:56 +0900, > Philippe Mathieu-Daudé wrote: >> >> Hi Yoshinori, >> >> On 6/25/20 11:25 AM, Peter Maydell wrote: >>> On Sun, 21 Jun 2020 at 13:54, Philippe Mathieu-Daudé >>> wrote: From: Yoshinori Sato renesas_

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-07-07 Thread Yoshinori Sato
On Mon, 29 Jun 2020 18:58:56 +0900, Philippe Mathieu-Daudé wrote: > > Hi Yoshinori, > > On 6/25/20 11:25 AM, Peter Maydell wrote: > > On Sun, 21 Jun 2020 at 13:54, Philippe Mathieu-Daudé > > wrote: > >> > >> From: Yoshinori Sato > >> > >> renesas_tmr: 8bit timer modules. > > > > Hi; the recen

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-07-06 Thread Philippe Mathieu-Daudé
ping...? On 6/29/20 11:58 AM, Philippe Mathieu-Daudé wrote: > Hi Yoshinori, > > On 6/25/20 11:25 AM, Peter Maydell wrote: >> On Sun, 21 Jun 2020 at 13:54, Philippe Mathieu-Daudé wrote: >>> >>> From: Yoshinori Sato >>> >>> renesas_tmr: 8bit timer modules. >> >> Hi; the recent Coverity run report

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-06-29 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 6/25/20 11:25 AM, Peter Maydell wrote: > On Sun, 21 Jun 2020 at 13:54, Philippe Mathieu-Daudé wrote: >> >> From: Yoshinori Sato >> >> renesas_tmr: 8bit timer modules. > > Hi; the recent Coverity run reports a potential bug in this > code: (CID 1429976) > > >> +static uint16_t

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-06-25 Thread Peter Maydell
On Thu, 25 Jun 2020 at 11:06, Thomas Huth wrote: > > On 25/06/2020 11.25, Peter Maydell wrote: > > Here execution can fall through but there is no 'break' or '/* fallthrough > > */'. > > Should we maybe start compiling with -Wimplicit-fallthrough if the > compiler supports it, so that we do not a

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-06-25 Thread Thomas Huth
On 25/06/2020 11.25, Peter Maydell wrote: [...] +static uint64_t tmr_read(void *opaque, hwaddr addr, unsigned size) +{ In this function Coverity reports a missing "break" (CID 1429977): +case A_TCORA: +if (size == 1) { +return tmr->tcora[ch]; +} else if (ch ==

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-06-25 Thread Peter Maydell
On Sun, 21 Jun 2020 at 13:54, Philippe Mathieu-Daudé wrote: > > From: Yoshinori Sato > > renesas_tmr: 8bit timer modules. Hi; the recent Coverity run reports a potential bug in this code: (CID 1429976) > +static uint16_t read_tcnt(RTMRState *tmr, unsigned size, int ch) > +{ > +int64_t delt

[PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-06-21 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato renesas_tmr: 8bit timer modules. This part use many renesas's CPU. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-