Re: [PULL 09/12] qga: add ssh-{add,remove}-authorized-keys

2020-11-02 Thread Markus Armbruster
Michael Roth writes: > On Mon, Nov 02, 2020 at 04:49:27PM +0100, Markus Armbruster wrote: [...] >> checkpatch ERROR: Use g_assert or g_assert_not_reached >> >> See commit 6e9389563e "checkpatch: Disallow glib asserts in main code" >> for rationale. > > Thanks for the pointer, I couldn't figure o

Re: [PULL 09/12] qga: add ssh-{add,remove}-authorized-keys

2020-11-02 Thread Michael Roth
On Mon, Nov 02, 2020 at 04:49:27PM +0100, Markus Armbruster wrote: > Michael Roth writes: > > > From: Marc-André Lureau > > > > Add new commands to add and remove SSH public keys from > > ~/.ssh/authorized_keys. > > > > I took a different approach for testing, including the unit tests right > >

Re: [PULL 09/12] qga: add ssh-{add,remove}-authorized-keys

2020-11-02 Thread Markus Armbruster
Michael Roth writes: > From: Marc-André Lureau > > Add new commands to add and remove SSH public keys from > ~/.ssh/authorized_keys. > > I took a different approach for testing, including the unit tests right > with the code. I wanted to overwrite the function to get the user > details, I couldn

[PULL 09/12] qga: add ssh-{add,remove}-authorized-keys

2020-10-27 Thread Michael Roth
From: Marc-André Lureau Add new commands to add and remove SSH public keys from ~/.ssh/authorized_keys. I took a different approach for testing, including the unit tests right with the code. I wanted to overwrite the function to get the user details, I couldn't easily do that over QMP. Furthermo