From: Paul Durrant
Signed-off-by: Paul Durrant
Signed-off-by: David Woodhouse
Reviewed-by: Paul Durrant
---
accel/xen/xen-all.c | 11 +-
hw/char/xen_console.c | 2 +-
hw/i386/kvm/xen_xenstore.c | 3 -
hw/i386/kvm/xenstore_impl.h | 8 +-
hw
On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote:
>
> From: Paul Durrant
>
> Signed-off-by: Paul Durrant
> Signed-off-by: David Woodhouse
> Reviewed-by: Paul Durrant
> ---
Hi; Coverity points out a memory leak in this code (CID 1508098):
> +static struct qemu_xs_handle *libxenstore_open(vo
On Tue, 2023-04-04 at 18:35 +0100, Peter Maydell wrote:
> On Tue, 7 Mar 2023 at 18:27, David Woodhouse
> wrote:
> >
> > From: Paul Durrant
> >
> > Signed-off-by: Paul Durrant
> > Signed-off-by: David Woodhouse
> > Reviewed-by: Paul Durrant
> > ---
>
> Hi; Coverity points out a memory leak i
On Tue, 4 Apr 2023 at 18:45, David Woodhouse wrote:
>
> On Tue, 2023-04-04 at 18:35 +0100, Peter Maydell wrote:
> > On Tue, 7 Mar 2023 at 18:27, David Woodhouse
> > wrote:
> > >
> > > From: Paul Durrant
> > >
> > > Signed-off-by: Paul Durrant
> > > Signed-off-by: David Woodhouse
> > > Reviewed
On Tue, 2023-04-04 at 18:45 +0100, Peter Maydell wrote:
> On Tue, 4 Apr 2023 at 18:45, David Woodhouse
> wrote:
> >
> > On Tue, 2023-04-04 at 18:35 +0100, Peter Maydell wrote:
> > > On Tue, 7 Mar 2023 at 18:27, David Woodhouse
> > >
> > > wrote:
> > > >
> > > > From: Paul Durrant
> > > >
> >
On Tue, Mar 7, 2023 at 1:29 PM David Woodhouse wrote:
>
> From: Paul Durrant
>
> Signed-off-by: Paul Durrant
> Signed-off-by: David Woodhouse
> Reviewed-by: Paul Durrant
> ---
> accel/xen/xen-all.c | 11 +-
> hw/char/xen_console.c | 2 +-
> hw/i386/kvm/xen_xen
On Sun, 2023-03-12 at 15:19 -0400, Jason Andryuk wrote:
>
> This breaks dm_restrict=1 since the xs_open is not allowed by the
> time
> this is called. There are other evtchn errors before this as well:
> # cat /var/log/xen/qemu-dm-debian.log
> char device redirected to /dev/pts/8 (label serial0)
Hi, David,
On Mon, Mar 13, 2023 at 4:45 AM David Woodhouse wrote:
>
> On Sun, 2023-03-12 at 15:19 -0400, Jason Andryuk wrote:
> >
> > This breaks dm_restrict=1 since the xs_open is not allowed by the
> > time
> > this is called. There are other evtchn errors before this as well:
> > # cat /var/l
On Mon, 2023-03-13 at 19:17 -0400, Jason Andryuk wrote:
> This looks good, better than what I posted, and seems to work for both
> dm_restrict set and unset.
Thanks.
> For dm_restricted, xs_write() does fail. I verified that with a print
> statement. I think "shouldn't even try" makes sense. I