Re: [PULL 13/32] cpus: Fix configure_icount() error API violation

2020-05-08 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 29 Apr 2020 at 08:34, Markus Armbruster wrote: >> >> The Error ** argument must be NULL, _abort, _fatal, or a >> pointer to a variable containing NULL. Passing an argument of the >> latter kind twice without clearing it in between is wrong: if the >> first call

Re: [PULL 13/32] cpus: Fix configure_icount() error API violation

2020-05-07 Thread Peter Maydell
On Wed, 29 Apr 2020 at 08:34, Markus Armbruster wrote: > > The Error ** argument must be NULL, _abort, _fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer

[PULL 13/32] cpus: Fix configure_icount() error API violation

2020-04-29 Thread Markus Armbruster
The Error ** argument must be NULL, _abort, _fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. configure_icount() is wrong that