Re: [PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts

2022-07-27 Thread Kevin Wolf
Am 07.07.2022 um 22:24 hat Peter Maydell geschrieben: > On Mon, 4 Jul 2022 at 05:50, Markus Armbruster wrote: > > My initial (knee-jerk) reaction to breaking array properties: Faster, > > Pussycat! Kill! Kill! > > In an ideal world, what would you replace them with? The next (and final) patch

Re: The case for array properties (was: [PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts)

2022-07-11 Thread Peter Maydell
On Fri, 8 Jul 2022 at 12:40, Markus Armbruster wrote: > > Cc'ing QOM maintainers. > > Peter Maydell writes: > > > On Mon, 4 Jul 2022 at 05:50, Markus Armbruster wrote: > >> My initial (knee-jerk) reaction to breaking array properties: Faster, > >> Pussycat! Kill! Kill! > > > > In an ideal

Re: The case for array properties (was: [PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts)

2022-07-08 Thread Daniel P . Berrangé
On Fri, Jul 08, 2022 at 01:40:43PM +0200, Markus Armbruster wrote: > Cc'ing QOM maintainers. > > Peter Maydell writes: > > > On Mon, 4 Jul 2022 at 05:50, Markus Armbruster wrote: > >> My initial (knee-jerk) reaction to breaking array properties: Faster, > >> Pussycat! Kill! Kill! > > > > In an

The case for array properties (was: [PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts)

2022-07-08 Thread Markus Armbruster
Cc'ing QOM maintainers. Peter Maydell writes: > On Mon, 4 Jul 2022 at 05:50, Markus Armbruster wrote: >> My initial (knee-jerk) reaction to breaking array properties: Faster, >> Pussycat! Kill! Kill! > > In an ideal world, what would you replace them with? Let's first recapitulate their

Re: [PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts

2022-07-07 Thread Peter Maydell
On Mon, 4 Jul 2022 at 05:50, Markus Armbruster wrote: > My initial (knee-jerk) reaction to breaking array properties: Faster, > Pussycat! Kill! Kill! In an ideal world, what would you replace them with? thanks -- PMM

Re: [PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts

2022-07-05 Thread Markus Armbruster
Markus Armbruster writes: > Peter Maydell writes: > >> On Fri, 15 Oct 2021 at 16:01, Kevin Wolf wrote: >>> QDicts are both what QMP natively uses and what the keyval parser >>> produces. Going through QemuOpts isn't useful for either one, so switch >>> the main device creation function to

Re: [PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts

2022-07-03 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 15 Oct 2021 at 16:01, Kevin Wolf wrote: >> QDicts are both what QMP natively uses and what the keyval parser >> produces. Going through QemuOpts isn't useful for either one, so switch >> the main device creation function to QDicts. By sharing more code with >>

Re: [PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts

2022-07-01 Thread Peter Maydell
On Fri, 15 Oct 2021 at 16:01, Kevin Wolf wrote: > QDicts are both what QMP natively uses and what the keyval parser > produces. Going through QemuOpts isn't useful for either one, so switch > the main device creation function to QDicts. By sharing more code with > the -object/object-add code

[PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts

2021-10-15 Thread Kevin Wolf
QDicts are both what QMP natively uses and what the keyval parser produces. Going through QemuOpts isn't useful for either one, so switch the main device creation function to QDicts. By sharing more code with the -object/object-add code path, we can even reduce the code size a bit. This commit