Re: [PULL 38/56] hw/acpi: changes towards enabling -Wshadow=local

2023-10-02 Thread Michael S. Tsirkin
On Sat, Sep 30, 2023 at 10:41:12AM +0200, Markus Armbruster wrote: > Ani Sinha writes: > > >> On 29-Sep-2023, at 2:20 PM, Markus Armbruster wrote: > >> > >> From: Ani Sinha > >> > >> Code changes in acpi that addresses all compiler complaints coming from > >> enabling > >> -Wshadow flags. En

Re: [PULL 38/56] hw/acpi: changes towards enabling -Wshadow=local

2023-09-30 Thread Markus Armbruster
Ani Sinha writes: >> On 29-Sep-2023, at 2:20 PM, Markus Armbruster wrote: >> >> From: Ani Sinha >> >> Code changes in acpi that addresses all compiler complaints coming from >> enabling >> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing >> other local variables o

Re: [PULL 38/56] hw/acpi: changes towards enabling -Wshadow=local

2023-09-29 Thread Ani Sinha
> On 29-Sep-2023, at 2:20 PM, Markus Armbruster wrote: > > From: Ani Sinha > > Code changes in acpi that addresses all compiler complaints coming from > enabling > -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing > other local variables or parameters. These makes

[PULL 38/56] hw/acpi: changes towards enabling -Wshadow=local

2023-09-29 Thread Markus Armbruster
From: Ani Sinha Code changes in acpi that addresses all compiler complaints coming from enabling -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing other local variables or parameters. These makes the code confusing and/or adds bugs that are difficult to catch. See also